The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org,
	Andrew Morton <akpm@osdl.org>
Subject: Re: + i386-lapic-timer-calibration.patch added to -mm tree
Date: Wed, 8 Nov 2006 13:28:26 +0100	[thread overview]
Message-ID: <20061108122826.GA23268@elte.hu> (raw)
In-Reply-To: <1162988830.8335.33.camel@localhost.localdomain>


* Thomas Gleixner <tglx@linutronix.de> wrote:

> On Wed, 2006-11-08 at 13:09 +0100, Ingo Molnar wrote:
> > one question:
> > 
> > > +	long tapic = apic_read(APIC_TMCCT);
> > > +	unsigned long pm = acpi_pm_read_early();
> > 
> > is this function call safe if the box has no pm-timer?
> 
> That's in the pm-timer-allow-early-access.patch:
> 
> Subject: pmtimer: Allow early access to pm timer
> 
> +static inline u32 acpi_pm_read_early(void)
> +{
> +       if (!pmtmr_ioport)
> +               return 0;
> +       /* mask the output to 24 bits */
> +       return acpi_pm_read_verified();
> +}
> 
> If pmtmr is not available, the function returns 0, so the resulting 
> delta is 0 and therefor ignored. Same applies, when PMTIMER is 
> disabled in the config.

ok, looks good.

	Ingo

      reply	other threads:[~2006-11-08 12:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200611012045.kA1KjM1p018949@shell0.pdx.osdl.net>
2006-11-08 12:09 ` + i386-lapic-timer-calibration.patch added to -mm tree Ingo Molnar
2006-11-08 12:27   ` Thomas Gleixner
2006-11-08 12:28     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061108122826.GA23268@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox