From: Akinobu Mita <akinobu.mita@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] input: check whether serio dirver registration is completed
Date: Wed, 8 Nov 2006 21:40:10 +0900 [thread overview]
Message-ID: <20061108124010.GD14871@localhost> (raw)
In-Reply-To: <20061108123636.GA14871@localhost>
This patch adds a flag to serio driver indicating whether registration is
complete and check that flag in serio_unregister_driver.
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
drivers/input/serio/serio.c | 7 ++++++-
include/linux/serio.h | 1 +
2 files changed, 7 insertions(+), 1 deletion(-)
Index: work-fault-inject/include/linux/serio.h
===================================================================
--- work-fault-inject.orig/include/linux/serio.h
+++ work-fault-inject/include/linux/serio.h
@@ -68,6 +68,7 @@ struct serio_driver {
void (*cleanup)(struct serio *);
struct device_driver driver;
+ int registered;
};
#define to_serio_driver(d) container_of(d, struct serio_driver, driver)
Index: work-fault-inject/drivers/input/serio/serio.c
===================================================================
--- work-fault-inject.orig/drivers/input/serio/serio.c
+++ work-fault-inject/drivers/input/serio/serio.c
@@ -804,6 +804,8 @@ static void serio_add_driver(struct seri
printk(KERN_ERR
"serio: driver_register() failed for %s, error: %d\n",
drv->driver.name, error);
+ else
+ drv->registered = 1;
}
int __serio_register_driver(struct serio_driver *drv, struct module *owner)
@@ -830,7 +832,10 @@ start_over:
}
}
- driver_unregister(&drv->driver);
+ if (drv->registered) {
+ driver_unregister(&drv->driver);
+ drv->registered = 0;
+ }
mutex_unlock(&serio_mutex);
}
next prev parent reply other threads:[~2006-11-08 12:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-07 12:06 [PATCH 1/2] input: make serio_register_driver() return error code Akinobu Mita
2006-11-07 14:20 ` Dmitry Torokhov
2006-11-08 12:36 ` Akinobu Mita
2006-11-08 12:38 ` [PATCH 1/4] input: make serio_register_driver() return error Akinobu Mita
2006-11-08 12:39 ` [PATCH 2/4] input: check serio_register_driver() error Akinobu Mita
2006-11-08 12:40 ` Akinobu Mita [this message]
2006-11-11 16:12 ` [PATCH 3/4] input: check whether serio dirver registration is completed Alexey Dobriyan
2006-11-08 12:41 ` [PATCH 4/4] input: change to GFP_KERNEL for SERIO_REGISTER_DRIVER event allocation Akinobu Mita
2006-11-17 6:37 ` [PATCH 1/2] input: make serio_register_driver() return error code Dmitry Torokhov
2006-11-18 6:51 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061108124010.GD14871@localhost \
--to=akinobu.mita@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox