From: Randy Dunlap <randy.dunlap@oracle.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
Dave Jones <davej@codemonkey.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gx-suspmod: fix "&& 0xff" typo
Date: Wed, 8 Nov 2006 14:10:07 -0800 [thread overview]
Message-ID: <20061108141007.e0adf333.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20061108220435.GA4972@martell.zuzino.mipt.ru>
On Thu, 9 Nov 2006 01:04:35 +0300 Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> arch/i386/kernel/cpu/cpufreq/gx-suspmod.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
> +++ b/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
> @@ -473,7 +473,7 @@ static int __init cpufreq_gx_init(void)
> pci_read_config_byte(params->cs55x0, PCI_MODON, &(params->on_duration));
> pci_read_config_byte(params->cs55x0, PCI_MODOFF, &(params->off_duration));
> pci_read_config_dword(params->cs55x0, PCI_CLASS_REVISION, &class_rev);
> - params->pci_rev = class_rev && 0xff;
> + params->pci_rev = class_rev & 0xff;
Hi,
any kind of automated detection on that one?
thanks,
---
~Randy
next prev parent reply other threads:[~2006-11-08 22:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-08 22:04 [PATCH] gx-suspmod: fix "&& 0xff" typo Alexey Dobriyan
2006-11-08 22:10 ` Randy Dunlap [this message]
2006-11-08 22:16 ` Dave Jones
2006-11-08 22:20 ` Alexey Dobriyan
2006-11-08 22:50 ` Dave Jones
2006-11-09 4:24 ` Willy Tarreau
2006-11-10 20:16 ` Horst H. von Brand
2006-11-08 22:11 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061108141007.e0adf333.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox