From: Ingo Molnar <mingo@elte.hu>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@redhat.com>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19-rc3] i386/io_apic: fix compiler warning in create_irq
Date: Thu, 9 Nov 2006 11:31:35 +0100 [thread overview]
Message-ID: <20061109103135.GA3748@elte.hu> (raw)
In-Reply-To: <20061031190955.GU27968@stusta.de>
* Adrian Bunk <bunk@stusta.de> wrote:
> On Tue, Oct 31, 2006 at 12:15:02PM +0100, Ingo Molnar wrote:
> >...
> > we definitely do not want to hide these places. They both make the
> > code less readable (why initialize it to some value if that value is
> > never used) and they hide the problem from the GCC folks too.
>
> What about cases where it's technically impossible for gcc to ever see
> that a variable actually gets initialized?
we should mark them as such or even initialize them outright. But these
are the exception.
Ingo
prev parent reply other threads:[~2006-11-09 10:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-29 21:04 [PATCH 2.6.19-rc3] i386/io_apic: fix compiler warning in create_irq Stefan Richter
2006-10-30 9:02 ` Ingo Molnar
2006-10-31 1:04 ` Andrew Morton
2006-10-31 9:37 ` Ingo Molnar
2006-10-31 9:49 ` Andrew Morton
2006-10-31 11:15 ` Ingo Molnar
2006-10-31 19:09 ` Adrian Bunk
2006-11-09 10:31 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061109103135.GA3748@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox