From: David Brownell <david-b@pacbell.net>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-usb-devel@lists.sourceforge.net, greg@kroah.com,
linux-kernel@vger.kernel.org
Subject: Re: [linux-usb-devel] drivers/usb/gadget/ether.c: NULL dereference
Date: Sat, 11 Nov 2006 23:10:17 -0800 [thread overview]
Message-ID: <200611112310.18903.david-b@pacbell.net> (raw)
In-Reply-To: <20061112065008.GF25057@stusta.de>
>
> void dev_kfree_skb_any(struct sk_buff *skb)
> {
> if (in_irq() || irqs_disabled())
> dev_kfree_skb_irq(skb);
> else
> dev_kfree_skb(skb);
> }
>
>
> And the first thing dev_kfree_skb_irq() does is to dereference skb...
Yet dev_kfree_skb() --> kfree_skb() starts with the standard idiom
if (unlikely(!skb))
return
Seems to me that the finger of blame is more appropriately pointed
at either dev_kfree_skb_any() or dev_kfree_skb_irq() ...
- Dave
next prev parent reply other threads:[~2006-11-12 7:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-11 16:06 drivers/usb/gadget/ether.c: NULL dereference Adrian Bunk
2006-11-12 6:35 ` [linux-usb-devel] " David Brownell
2006-11-12 6:50 ` Adrian Bunk
2006-11-12 7:10 ` David Brownell [this message]
2006-11-12 12:23 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611112310.18903.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=bunk@stusta.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox