From: Dave Jones <davej@redhat.com>
To: "Martin J. Bligh" <mbligh@mbligh.org>
Cc: akpm@osdl.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
cmm@us.ibm.com, val_henson@linux.intel.com
Subject: Re: [PATCH] Bring ext2 reservations code in line with latest ext3
Date: Sun, 12 Nov 2006 23:50:39 -0500 [thread overview]
Message-ID: <20061113045039.GE6591@redhat.com> (raw)
In-Reply-To: <4557BFD7.5010405@mbligh.org>
On Sun, Nov 12, 2006 at 04:44:07PM -0800, Martin J. Bligh wrote:
> Did a pass through comparing the functions changed by the ext2
> reservations patch to current ext3 code. Fixed up comments and
> typedefs to match latest ext3 code.
>
> Only thing left remaining was the error handling in
> ext2_try_to_allocate_with_rsv, but it may be OK as is.
>
> Signed-off-by: Martin J. Bligh <mbligh@google.com>
> +/*
> + * rsv_is_empty() -- Check if the reservation window is allocated.
> + * @rsv: given reservation window to check
> + *
> + * returns 1 if the end block is EXT3_RESERVE_WINDOW_NOT_ALLOCATED.
> + */
s/EXT3/EXT2/ ?
> static inline int rsv_is_empty(struct ext2_reserve_window *rsv)
> {
> /* a valid reservation end block could not be 0 */
> return (rsv->_rsv_end == EXT2_RESERVE_WINDOW_NOT_ALLOCATED);
> }
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-11-13 4:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200611090841.kA98feVx010502@shell0.pdx.osdl.net>
2006-11-13 0:44 ` [PATCH] Bring ext2 reservations code in line with latest ext3 Martin J. Bligh
2006-11-13 4:50 ` Dave Jones [this message]
2006-11-13 7:45 ` Martin J. Bligh
2006-11-13 7:59 ` Arjan van de Ven
2006-11-14 0:59 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061113045039.GE6591@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=cmm@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@mbligh.org \
--cc=val_henson@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox