public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: thunder7@xs4all.nl
To: Neil Brown <neilb@suse.de>
Cc: Jurriaan <thunder7@xs4all.nl>, linux-kernel@vger.kernel.org
Subject: Re: trouble with mounting a 1.5 TB raid6 volume in 2.6.19-rc5-mm1
Date: Mon, 13 Nov 2006 18:43:41 +0100	[thread overview]
Message-ID: <20061113174341.GA3819@amd64.of.nowhere> (raw)
In-Reply-To: <17752.15962.816035.80638@cse.unsw.edu.au>

From: Neil Brown <neilb@suse.de>
Date: Mon, Nov 13, 2006 at 08:43:54PM +1100
> On Monday November 13, neilb@suse.de wrote:
> > 
> > Can you try reverting this patch (patch -p1 -R) ?
> > 
> 
> Yes, I'm confident that reverting that patch will fix your problem.
> I actually found a number of errors while tracking this down :-(

Oops. Do you have some kind of test-suite to run on md-devices before
releasing a patch? I didn't think my hardware was that exotic.

I had a scary moment just now, since 2.6.19-rc5-mm1 without your patch
wanted to fsck the volume, and started repairing errors which didn't
exist on disk. Luckily, it stopped before inode 64, and I was able to
fsck the volume on an earlier kernel without apparent damage.

Still, a test suite seems like a good idea. Also, getting Andrew to
either add this as a hot-fix or release -mm2 would be a good idea,
IMVHO.


> The following patch makes everything happy for me, but I'll be
> revising it and splitting it up before submitting it (Andrew: please
> don't just grab it from here :-)

It works for me. I can mount the partition, read it, create files, all
is OK.

> Thanks again for the report.

No problem - I'm glad to be able to do something back for all your (yes,
that's you, kernel developers) hard work. If this had actually corrupted
my hdtv streams collection, I would have been a trifle less
enthousiastic, of course.

Kind regards,
Jurriaan
-- 
Sir Humphrey: "It is characteristic of all committee discussions and
decisions that every member has a vivid recollection of them and that
every member's recollection of them differs violently from every other
member's recollection."
	Yes Prime Minister
Debian (Unstable) GNU/Linux 2.6.19-rc5-mm1 2x4826 bogomips load 0.48

  reply	other threads:[~2006-11-13 17:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-11 18:38 trouble with mounting a 1.5 TB raid6 volume in 2.6.19-rc5-mm1 jurriaan
2006-11-11 19:04 ` thunder7
2006-11-13  5:01 ` Neil Brown
2006-11-13  9:43   ` Neil Brown
2006-11-13 17:43     ` thunder7 [this message]
2006-11-13 23:57       ` Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061113174341.GA3819@amd64.of.nowhere \
    --to=thunder7@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox