From: Andi Kleen <ak@suse.de>
To: Ernie Petrides <petrides@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64: fix perms/range of vsyscall vma in /proc/*/maps
Date: Tue, 14 Nov 2006 03:52:54 +0100 [thread overview]
Message-ID: <200611140352.54669.ak@suse.de> (raw)
In-Reply-To: <200611140251.kAE2pm0Z015391@pasta.boston.redhat.com>
On Tuesday 14 November 2006 03:51, Ernie Petrides wrote:
> On Friday, 10-Nov-2006 at 6:07 +0100, Andi Kleen wrote:
>
> > On Friday 10 November 2006 02:20, Ernie Petrides wrote:
> >
> > > Hi, Andi. The final line of /proc/<pid>/maps on x86_64 for native 64-bit
> > > tasks shows an incorrect ending address and incorrect permissions. There
> > > is only a single page mapped in this vsyscall region, and it is accessible
> > > for both read and execute.
> >
> > The range reported is how much address space is reserved, but you're
> > right it is less.
> >
> > But I don't like hardcoding a page here -- this will likely be extended
> > soon. Can you please create a new define VSYSCALL_REAL_LENGTH or similar
> > in vsyscall.h and use that?
>
> Good idea -- how about the patch below?
Added thanks. Probably for .20, i don't think it's critical enough for .19
unless someone feels strongly about it.
-Andi
P.S.: When you retransmit patches please always include the original description
for the changelog too.
prev parent reply other threads:[~2006-11-14 2:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 1:20 [PATCH] x86_64: fix perms/range of vsyscall vma in /proc/*/maps Ernie Petrides
2006-11-10 5:07 ` Andi Kleen
2006-11-14 2:51 ` Ernie Petrides
2006-11-14 2:52 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611140352.54669.ak@suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=petrides@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox