Re: 2.6.19-rc1 (+ide-cd patches) regression: unable to rip cd

Jens Axboe
2006-11-13T20:00:23Z

On Fri, Nov 10 2006, Alex Romosan wrote:
> Jens Axboe <jens.axboe@oracle.com> writes:
>
> > Can you retest with this? This must be where the wrong write bit comes
> > from.
> >
> > diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
> > index 2dc3264..a19338e 100644
> > --- a/block/scsi_ioctl.c
> > +++ b/block/scsi_ioctl.c
> > @@ -246,10 +246,10 @@ static int sg_io(struct file *file, requ
> > switch (hdr->dxfer_direction) {
> > default:
> > return -EINVAL;
> > - case SG_DXFER_TO_FROM_DEV:
> > case SG_DXFER_TO_DEV:
> > writing = 1;
> > break;
> > + case SG_DXFER_TO_FROM_DEV:
> > case SG_DXFER_FROM_DEV:
> > break;
> > }
> >
>
> i think this finally got it to work! when i start cdparanoia now i get
> (all the previous debug patches are still applied):
>
> kernel: ide-cd: starting INQ da76fee4
> kernel: ide-cd: newpc da76fee4
> kernel: ide-cd: newpc da76fee4
> kernel: ide-cd: newpc end INQ da76fee4
>
> and then when it gets to the parts where the cd might have some
> problems i get a bunch of:
>
> kernel: hdc: packet command error: status=0x51 { DriveReady SeekComplete Error }
> kernel: hdc: packet command error: error=0xb4 { AbortedCommand LastFailedSense=0x0b }
> kernel: ide: failed opcode was: unknown
> kernel: ATAPI device hdc:
> kernel: Error: Aborted command -- (Sense key=0x0b)
> kernel: (reserved error code) -- (asc=0x11, ascq=0x11)
> kernel: The failed "Read CD" packet command was:
> kernel: "be 00 00 00 51 93 00 00 0d f8 00 00 00 00 00 00 "
>
> but cdparanoia continues (albeit more slowly) and eventually finishes.
> thank you!

Great, problem fixed then, patch is already merged upstream so 2.6.19
and next -rc (if any :-) should work. Thanks for your persistent
testing.

--
Jens Axboe