From: Alan <alan@lxorguk.ukuu.org.uk>
To: Pavel Machek <pavel@ucw.cz>, linux-kernel@vger.kernel.org
Subject: Re: [patch] floppy: suspend/resume fix
Date: Wed, 15 Nov 2006 20:49:15 +0000 [thread overview]
Message-ID: <20061115204915.1d0717db@localhost.localdomain> (raw)
In-Reply-To: <20061115202418.GC3875@elf.ucw.cz>
On Wed, 15 Nov 2006 21:24:18 +0100
Pavel Machek <pavel@ucw.cz> wrote:
> On Tue 2006-11-14 11:34:21, Lee Revell wrote:
> > On Tue, 2006-11-14 at 12:09 +0100, Pavel Machek wrote:
> > > Suspending with mounted floppy is a user error.
> >
> > Huh? How so?
>
> Floppy is removable, and you are expected to umount removable devices
> before suspend.
That seems pretty crude. There are lots of cases where an apparently
removable device is/should be preserved properly and left mounted (eg
builtin CF).
We really want to be smarter than that - which means the drivers ought to
be doing stuff in their suspend/resume paths to figure out if the media
changed when really possible (eg IDE removable)
Floppy is probably not too fixable, but calling it a "user error" is
insulting - user expectation is reasonable that suspend/resume should
just work. The implementation is just rather trickier/nonsensical in this
case.
next prev parent reply other threads:[~2006-11-15 20:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-12 20:47 [patch] floppy: suspend/resume fix Mikael Pettersson
2006-11-12 21:29 ` Russell King
2006-11-12 22:03 ` Ingo Molnar
2006-11-12 23:54 ` Russell King
2006-11-14 11:09 ` Pavel Machek
2006-11-14 16:34 ` Lee Revell
2006-11-15 20:24 ` Pavel Machek
2006-11-15 20:34 ` Lee Revell
2006-11-15 20:49 ` Alan [this message]
2006-11-15 20:49 ` Pavel Machek
2006-11-15 21:03 ` Rafael J. Wysocki
2006-11-15 21:14 ` Arjan van de Ven
2006-11-16 12:38 ` Russell King
2006-11-15 18:46 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2006-11-12 22:40 Mikael Pettersson
2006-11-12 23:58 ` Russell King
2006-11-15 18:53 ` Ingo Molnar
[not found] <7grMO-2YO-55@gated-at.bofh.it>
[not found] ` <7gs69-46A-37@gated-at.bofh.it>
[not found] ` <7gtvd-7xg-23@gated-at.bofh.it>
2006-11-12 21:44 ` Bodo Eggert
2006-11-14 11:05 ` Pavel Machek
2006-11-12 17:53 Mikael Pettersson
2006-11-12 18:09 ` Ingo Molnar
2006-11-12 19:30 ` Andrew Morton
2006-11-12 20:35 ` Arjan van de Ven
2006-11-12 19:40 ` Russell King
2006-11-11 20:48 [BUG] floppy: broken after resume due to 2.6.18-rc1 lockdep changes Mikael Pettersson
2006-11-12 15:47 ` [patch] floppy: suspend/resume fix Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061115204915.1d0717db@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox