From: Jens Axboe <jens.axboe@oracle.com>
To: Edward Falk <efalk@google.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Introduce block I/O performance histograms
Date: Thu, 16 Nov 2006 21:21:57 +0100 [thread overview]
Message-ID: <20061116202156.GG7164@kernel.dk> (raw)
In-Reply-To: <455CC38A.20104@google.com>
On Thu, Nov 16 2006, Edward Falk wrote:
> Jens Axboe wrote:
>
> >I don't see the point at all for including this piece of code in the
> >kernel. You can do the same from user space. Your help entry said it
> >even grows the kernel size about 21k, that's pretty nasty.
>
> How would you do this from user space? Also, the 21k increase is only
> in effect if the feature is turned on in the config, and it's off by
> default.
You can use blktrace to do it. I realize that the 21k is only if it's
turned out, it's still quite a huge big (why does it turn out so big?).
The source is always there to maintain, though. The main point is that
you don't have to do this in the kernel, though.
--
Jens Axboe
next prev parent reply other threads:[~2006-11-16 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-16 3:15 [PATCH] Introduce block I/O performance histograms Edward Falk
2006-11-16 6:58 ` Jens Axboe
2006-11-16 20:01 ` Edward Falk
2006-11-16 20:21 ` Jens Axboe [this message]
2006-11-16 20:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061116202156.GG7164@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@osdl.org \
--cc=efalk@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).