Re: [patch 2.6.19-rc6] platform_driver_probe(), can save codespace

Dmitry Torokhov
2006-11-17T14:32:21Z

> +
> + /* Fixup that section violation, being paranoid about code scanning
> + * the list of drivers in order to probe new devices. Check to see
> + * if the probe was successful, and make sure any forced probes of
> + * new devices fail.
> + */
> + spin_lock(&platform_bus_type.klist_drivers.k_lock);
> + drv->probe = NULL;
> + if (code == 0 && list_empty(&drv->driver.klist_devices.k_list))
> + retval = -ENODEV;
> + drv->driver.probe = platform_drv_probe_fail;
> + spin_unlock(&platform_bus_type.klist_drivers.k_lock);

I think this code should not be executed if driver is compiled as a
module because __init sections will stay anyway. Also, why don't you
also remove "bind" attribute if driver is built-in. That should save a
bit of dynamic memory.

--
Dmitry