Re: [patch 3/6] [RFC] Add MMC Password Protection (lock/unlock) support V6

[Russell King <rmk+lkml@arm.linux.org.uk>]

On Fri, Nov 17, 2006 at 09:03:24AM -0400, Anderson Briglia wrote:
> @@ -101,7 +104,7 @@ mmc_start_request(struct mmc_host *host,
>  	pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
>  		 mmc_hostname(host), mrq->cmd->opcode,
>  		 mrq->cmd->arg, mrq->cmd->flags);
> -
> +	

Random whitespace damage; please remove.

> +	do {
> +		/* we cannot use "retries" here because the
> +		 * R1_LOCK_UNLOCK_FAILED bit is cleared by subsequent reads 
> to

#include <std-mail-wrapping-complaint.h>

> +error:
> +	mmc_deselect_cards(card->host);

You don't need to deselect the card prior to releasing the host; in
fact in single card systems, it's better that you don't.  That way
you avoid generating lots of select card messages.

> +	mmc_card_release_host(card);
> +out:
> +	kfree(data_buf);
> +
> +	return err;
> +}
> +
> +//EXPORT_SYMBOL(mmc_lock_unlock);

Either export it or don't.  There's no point in having a commented out
export.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core