From: Adrian Bunk <bunk@stusta.de>
To: perex@suse.cz
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [RFC: 2.6 patch] make sound/core/control.c:snd_ctl_new() static
Date: Fri, 17 Nov 2006 18:02:26 +0100 [thread overview]
Message-ID: <20061117170226.GG31879@stusta.de> (raw)
Now that everyone uses snd_ctl_new1() and noone is using snd_ctl_new()
anymore, we can make it static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl | 10 ----------
include/sound/control.h | 1 -
sound/core/control.c | 5 ++---
3 files changed, 2 insertions(+), 14 deletions(-)
--- linux-2.6.19-rc5-mm2/Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl.old 2006-11-17 16:48:12.000000000 +0100
+++ linux-2.6.19-rc5-mm2/Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl 2006-11-17 16:48:22.000000000 +0100
@@ -3691,16 +3691,6 @@
</para>
<para>
- Here, the chip instance is retrieved via
- <function>snd_kcontrol_chip()</function> macro. This macro
- just accesses to kcontrol->private_data. The
- kcontrol->private_data field is
- given as the argument of <function>snd_ctl_new()</function>
- (see the later subsection
- <link linkend="control-interface-constructor"><citetitle>Constructor</citetitle></link>).
- </para>
-
- <para>
The <structfield>value</structfield> field is depending on
the type of control as well as on info callback. For example,
the sb driver uses this field to store the register offset,
--- linux-2.6.19-rc5-mm2/include/sound/control.h.old 2006-11-17 16:48:35.000000000 +0100
+++ linux-2.6.19-rc5-mm2/include/sound/control.h 2006-11-17 16:48:39.000000000 +0100
@@ -108,7 +108,6 @@
void snd_ctl_notify(struct snd_card * card, unsigned int mask, struct snd_ctl_elem_id * id);
-struct snd_kcontrol *snd_ctl_new(struct snd_kcontrol * kcontrol, unsigned int access);
struct snd_kcontrol *snd_ctl_new1(const struct snd_kcontrol_new * kcontrolnew, void * private_data);
void snd_ctl_free_one(struct snd_kcontrol * kcontrol);
int snd_ctl_add(struct snd_card * card, struct snd_kcontrol * kcontrol);
--- linux-2.6.19-rc5-mm2/sound/core/control.c.old 2006-11-17 16:48:46.000000000 +0100
+++ linux-2.6.19-rc5-mm2/sound/core/control.c 2006-11-17 16:49:39.000000000 +0100
@@ -183,7 +183,8 @@
*
* Returns the pointer of the new instance, or NULL on failure.
*/
-struct snd_kcontrol *snd_ctl_new(struct snd_kcontrol *control, unsigned int access)
+static struct snd_kcontrol *snd_ctl_new(struct snd_kcontrol *control,
+ unsigned int access)
{
struct snd_kcontrol *kctl;
unsigned int idx;
@@ -201,8 +202,6 @@
return kctl;
}
-EXPORT_SYMBOL(snd_ctl_new);
-
/**
* snd_ctl_new1 - create a control instance from the template
* @ncontrol: the initialization record
next reply other threads:[~2006-11-17 17:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 17:02 Adrian Bunk [this message]
2006-11-20 16:51 ` [Alsa-devel] [RFC: 2.6 patch] make sound/core/control.c:snd_ctl_new() static Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061117170226.GG31879@stusta.de \
--to=bunk@stusta.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox