public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Mike Galbraith <efault@gmx.de>
Cc: "Chen, Kenneth W" <kenneth.w.chen@intel.com>,
	nickpiggin@yahoo.com.au, "Siddha,
	Suresh B" <suresh.b.siddha@intel.com>,
	linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [rfc patch] Re: sched: incorrect argument used in task_hot()
Date: Fri, 17 Nov 2006 20:20:52 +0100	[thread overview]
Message-ID: <20061117192052.GA23272@elte.hu> (raw)
In-Reply-To: <1163782610.22574.59.camel@Homer.simpson.net>


* Mike Galbraith <efault@gmx.de> wrote:

> One way to improve granularity, and eliminate the possibility of 
> p->last_run being > rq->timestamp_tast_tick, and thereby short 
> circuiting the evaluation of cache_hot_time, is to cache the last 
> return of sched_clock() at both tick and sched times, and use that 
> value as our reference instead of the absolute time of the tick.  It 
> won't totally eliminate skew, but it moves the reference point closer 
> to the current time on the remote cpu.
> 
> Looking for a good place to do this, I chose update_cpu_clock().

looks good to me - thus we will update the timestamp not only in the 
timer tick, but also upon every context-switch (when we acquire 
sched_clock() value anyway). Lets try this in -mm?

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo

  parent reply	other threads:[~2006-11-17 19:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-14 23:00 sched: incorrect argument used in task_hot() Chen, Kenneth W
2006-11-17 16:56 ` [rfc patch] " Mike Galbraith
2006-11-17 19:20   ` Chen, Kenneth W
2006-11-17 19:20   ` Ingo Molnar [this message]
2006-11-17 19:41     ` Chen, Kenneth W
2006-11-17 21:30     ` Mike Galbraith
2006-11-17 21:39       ` Andrew Morton
2006-11-17 22:18         ` Mike Galbraith
2006-11-18  0:25           ` Chen, Kenneth W
2006-11-18  7:28             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061117192052.GA23272@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=efault@gmx.de \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=suresh.b.siddha@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox