From: Ingo Molnar <mingo@elte.hu>
To: Karsten Wiese <fzu@wemgehoertderstaat.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
Stephen Hemminger <shemminger@osdl.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH] Regard MSRs in lapic_suspend()/lapic_resume()
Date: Sat, 18 Nov 2006 08:03:10 +0100 [thread overview]
Message-ID: <20061118070310.GD32226@elte.hu> (raw)
In-Reply-To: <200611180300.18581.fzu@wemgehoertderstaat.de>
* Karsten Wiese <fzu@wemgehoertderstaat.de> wrote:
> Read/Write APIC_LVTPC and APIC_LVTTHMR only, if get_maxlvt() returns
> certain values. This is done like everywhere else in
> i386/kernel/apic.c, so I guess its correct. Suspends/Resumes to disk
> fine and eleminates an smp_error_interrupt() here on a K8.
>
> Signed-off-by: Karsten Wiese <fzu@wemgehoertderstaat.de>
nice one! I'm tempted to suggest this for 2.6.19 merge because it causes
the kernel to do less (so it has little risk of breaking something that
is working) ... who knows what happens on certain (older?) APICs when we
try to write back those bogus values.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2006-11-18 7:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-18 2:00 [PATCH] Regard MSRs in lapic_suspend()/lapic_resume() Karsten Wiese
2006-11-18 7:03 ` Ingo Molnar [this message]
2006-11-18 7:22 ` Ingo Molnar
2006-11-18 14:46 ` Ingo Molnar
2006-11-19 7:59 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061118070310.GD32226@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=fzu@wemgehoertderstaat.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox