From: Andi Kleen <ak@suse.de>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
reiserfs-dev@namesys.com, sam@ravnborg.org,
Jeff Mahoney <jeffm@suse.com>, Al Viro <viro@ftp.linux.org.uk>
Subject: Re: reiserfs NET=n build error
Date: Sun, 19 Nov 2006 06:50:49 +0100 [thread overview]
Message-ID: <200611190650.49282.ak@suse.de> (raw)
In-Reply-To: <20061118202206.01bdc0e0.randy.dunlap@oracle.com>
On Sunday 19 November 2006 05:22, Randy Dunlap wrote:
> With CONFIG_NET=n and REISERFS_FS=m (randconfig), kernel build ends with
>
> Kernel: arch/x86_64/boot/bzImage is ready (#15)
> Building modules, stage 2.
> MODPOST 137 modules
> WARNING: "csum_partial" [fs/reiserfs/reiserfs.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> on both 2.6.19-rc6 and 2.6.19-rc6-git2.
>
> Looks like arch/x86_64/lib/lib.a is not being linked into the
> final kernel image for some reason. lib.a does contain csum_partial.
iirc Al Viro has been cleaning that up. Essentially reiserfs should
use its own C copy of the checksum functions. Using csum_partial() is not
safe because its output varies by architecture.
I would copy a relatively simple C implementation, like arch/h8300/lib/checksum.c
-Andi
next prev parent reply other threads:[~2006-11-19 5:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-19 4:22 reiserfs NET=n build error Randy Dunlap
2006-11-19 5:50 ` Andi Kleen [this message]
2006-11-19 17:09 ` Jeff Mahoney
2006-11-19 18:59 ` Andi Kleen
2006-11-19 19:04 ` Randy Dunlap
2006-11-19 20:57 ` Al Viro
2006-11-19 21:02 ` Randy Dunlap
2006-11-19 22:32 ` Jeff Mahoney
2006-11-28 19:47 ` Randy Dunlap
2006-12-05 0:19 ` Randy Dunlap
2006-12-05 1:20 ` Neil Brown
2006-11-19 20:12 ` Jeff Mahoney
2006-11-19 20:52 ` Al Viro
2006-11-19 14:13 ` Adrian Bunk
2006-11-19 14:53 ` [discuss] " Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611190650.49282.ak@suse.de \
--to=ak@suse.de \
--cc=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=reiserfs-dev@namesys.com \
--cc=sam@ravnborg.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox