From: David Brownell <david-b@pacbell.net>
To: Alessandro Zummo <alessandro.zummo@towertech.it>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: [patch 2.6.19-rc6 3/6] X86_PC optionally creates rtc_cmos platform device
Date: Mon, 20 Nov 2006 10:22:09 -0800 [thread overview]
Message-ID: <200611201022.09709.david-b@pacbell.net> (raw)
In-Reply-To: <200611201014.41980.david-b@pacbell.net>
Update X86_PC platforms (i386, x86_64) to create an "rtc_cmos" platform device
when PNPACPI won't be creating a corresponding PNP node for us. There may be
other platform devices that should get corresponding treatment; it might help
get rid of more legacy ISA probing logic.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Index: g26/arch/x86_64/kernel/setup.c
===================================================================
--- g26.orig/arch/x86_64/kernel/setup.c 2006-11-20 10:03:06.000000000 -0800
+++ g26/arch/x86_64/kernel/setup.c 2006-11-20 10:10:43.000000000 -0800
@@ -1212,22 +1212,58 @@ struct seq_operations cpuinfo_op = {
.show = show_cpuinfo,
};
-#if defined(CONFIG_INPUT_PCSPKR) || defined(CONFIG_INPUT_PCSPKR_MODULE)
+
+#ifdef CONFIG_X86_PC
+
#include <linux/platform_device.h>
-static __init int add_pcspkr(void)
-{
- struct platform_device *pd;
- int ret;
+#include <asm/mc146818rtc.h>
+
+#if defined(CONFIG_INPUT_PCSPKR) || defined(CONFIG_INPUT_PCSPKR_MODULE)
+static struct platform_device pcspkr_dev = {
+ .name = "pcspkr",
+ .id = -1,
+};
+#endif /* PCSPKR */
- pd = platform_device_alloc("pcspkr", -1);
- if (!pd)
- return -ENOMEM;
-
- ret = platform_device_add(pd);
- if (ret)
- platform_device_put(pd);
+#ifndef CONFIG_PNPACPI
+struct resource rtc_platform_resources[] = { {
+ .flags = IORESOURCE_IO,
+ .start = RTC_PORT(0),
+ .end = RTC_PORT(1),
+}, {
+ .flags = IORESOURCE_IRQ,
+ .start = RTC_IRQ
+} };
- return ret;
-}
-device_initcall(add_pcspkr);
+struct platform_device rtc_dev = {
+ .name = "rtc_cmos",
+ .id = -1,
+ .resource = rtc_platform_resources,
+ .num_resources = ARRAY_SIZE(rtc_platform_resources),
+};
+#endif /* !PNPACPI */
+
+static struct platform_device *x86_pc_devs[] __initdata = {
+#if defined(CONFIG_INPUT_PCSPKR) || defined(CONFIG_INPUT_PCSPKR_MODULE)
+ &pcspkr_dev,
+#endif
+#ifndef CONFIG_PNPACPI
+ &rtc_dev,
+#endif
+};
+
+static __init int add_devices(void)
+{
+#ifndef CONFIG_PNPACPI
+ /* On most motherboards starting with ATX (1995+),
+ * RTC alarms can wake the system
+ */
+ device_init_wakeup(&rtc_dev.dev, 1);
#endif
+
+ return platform_add_devices(x86_pc_devs, ARRAY_SIZE(x86_pc_devs));
+}
+arch_initcall(add_devices);
+
+#endif /* X86_PC */
+
Index: g26/arch/i386/kernel/setup.c
===================================================================
--- g26.orig/arch/i386/kernel/setup.c 2006-11-20 10:03:06.000000000 -0800
+++ g26/arch/i386/kernel/setup.c 2006-11-20 10:10:43.000000000 -0800
@@ -1481,22 +1481,56 @@ void __init setup_arch(char **cmdline_p)
tsc_init();
}
-static __init int add_pcspkr(void)
-{
- struct platform_device *pd;
- int ret;
- pd = platform_device_alloc("pcspkr", -1);
- if (!pd)
- return -ENOMEM;
-
- ret = platform_device_add(pd);
- if (ret)
- platform_device_put(pd);
+#ifdef CONFIG_X86_PC
+
+#include <linux/platform_device.h>
+#include <asm/mc146818rtc.h>
+
+static struct platform_device pcspkr_dev = {
+ .name = "pcspkr",
+ .id = -1,
+};
+
+#ifndef CONFIG_PNPACPI
+struct resource rtc_platform_resources[] = { {
+ .flags = IORESOURCE_IO,
+ .start = RTC_PORT(0),
+ .end = RTC_PORT(1),
+}, {
+ .flags = IORESOURCE_IRQ,
+ .start = RTC_IRQ
+} };
+
+struct platform_device rtc_dev = {
+ .name = "rtc_cmos",
+ .id = -1,
+ .resource = rtc_platform_resources,
+ .num_resources = ARRAY_SIZE(rtc_platform_resources),
+};
+#endif /* !PNPACPI */
- return ret;
+static struct platform_device *x86_pc_devs[] __initdata = {
+ &pcspkr_dev,
+#ifndef CONFIG_PNPACPI
+ &rtc_dev,
+#endif
+};
+
+static __init int add_devices(void)
+{
+#ifndef CONFIG_PNPACPI
+ /* On most motherboards starting with ATX (1995+),
+ * RTC alarms can wake the system
+ */
+ device_init_wakeup(&rtc_dev.dev, 1);
+#endif
+
+ return platform_add_devices(x86_pc_devs, ARRAY_SIZE(x86_pc_devs));
}
-device_initcall(add_pcspkr);
+arch_initcall(add_devices);
+
+#endif /* X86_PC */
/*
* Local Variables:
next prev parent reply other threads:[~2006-11-20 22:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-20 18:14 [patch 2.6.19-rc6 0/6] more rtc framework/driver updates David Brownell
2006-11-20 18:17 ` [patch 2.6.19-rc6 1/6] rtc class /proc/driver/rtc update David Brownell
2006-11-20 23:13 ` Alessandro Zummo
2006-11-21 2:47 ` [Bulk] " David Brownell
2006-11-22 20:37 ` Alessandro Zummo
2006-11-23 0:39 ` David Brownell
2006-11-20 18:19 ` [patch 2.6.19-rc6 2/6] rtc-sa1100 tweaks David Brownell
2006-11-20 22:48 ` Russell King
2006-11-21 1:46 ` David Brownell
2006-11-20 18:22 ` David Brownell [this message]
2006-11-20 18:27 ` [patch 2.6.19-rc6 5/6] rtc-cmos driver David Brownell
2006-11-20 18:27 ` [patch 2.6.19-rc6 4/6] ACPI exports RTC extensions through platform_data David Brownell
2006-11-20 18:28 ` [patch 2.6.19-rc6 6/6] rtc-omap driver David Brownell
2006-11-20 23:09 ` Alessandro Zummo
2006-11-22 1:19 ` Andrew Morton
2006-11-22 2:15 ` David Brownell
2006-11-22 2:28 ` Andrew Morton
2006-11-23 0:09 ` David Brownell
2006-11-22 20:34 ` Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611201022.09709.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=alessandro.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox