From: Alan <alan@lxorguk.ukuu.org.uk>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: first proposal for pci resume quirk interface
Date: Mon, 20 Nov 2006 15:47:29 +0000 [thread overview]
Message-ID: <20061120154729.45003599@localhost.localdomain> (raw)
In-Reply-To: <20061120152041.GA4199@ucw.cz>
On Mon, 20 Nov 2006 15:20:41 +0000
Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>
> Looks okay to me.
>
>
> > #define DECLARE_PCI_FIXUP_ENABLE(vendor, device, hook) \
> > DECLARE_PCI_FIXUP_SECTION(.pci_fixup_enable, \
> > vendor##device##hook, vendor, device, hook)
> > +#define DECLARE_PCI_FIXUP_RESUME(vendor, device, hook) \
> > + DECLARE_PCI_FIXUP_SECTION(.pci_fixup_resume, \
> > + resume##vendor##device##hook, vendor, device, hook)
>
> Maybe having DECLARE_PCI_FIXUP_ALWAYS (meaning ENABLE+RESUME) would reduce the code
> duplication?
There is almost no duplication if you actually look at the output of the
code. It simply generates entries into two jump/match tables. Doing a
PCI_FIXUP for both is ugly because of the ordering requirements.
Alan
next prev parent reply other threads:[~2006-11-20 15:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-14 17:55 [PATCH]: first proposal for pci resume quirk interface Alan
2006-11-20 15:20 ` Pavel Machek
2006-11-20 15:47 ` Alan [this message]
2006-11-21 14:59 ` Carl-Daniel Hailfinger
2006-11-21 15:06 ` Alan
2006-12-04 12:51 ` Jean Delvare
2006-12-04 13:14 ` Alan
2006-12-04 17:37 ` [PATCH] PCI: reenable Asus SMBus quirks on resume Jean Delvare
2006-12-04 19:59 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061120154729.45003599@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox