public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Akinobu Mita <akinobu.mita@gmail.com>,
	Jiri Slaby <jirislaby@gmail.com>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] driver core: delete virtual directory on class_unregister()
Date: Mon, 20 Nov 2006 12:34:40 -0800	[thread overview]
Message-ID: <20061120203440.GA5458@suse.de> (raw)
In-Reply-To: <20061120195318.GB18077@APFDCB5C>

On Tue, Nov 21, 2006 at 04:53:18AM +0900, Akinobu Mita wrote:
> Class virtual directory is created as the need arises.
> But it is not deleted when the class is unregistered.
> 
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> 
> ---
>  drivers/base/class.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Index: work-fault-inject/drivers/base/class.c
> ===================================================================
> --- work-fault-inject.orig/drivers/base/class.c
> +++ work-fault-inject/drivers/base/class.c
> @@ -163,6 +163,8 @@ int class_register(struct class * cls)
>  void class_unregister(struct class * cls)
>  {
>  	pr_debug("device class '%s': unregistering\n", cls->name);
> +	if (cls->virtual_dir)
> +		kobject_unregister(cls->virtual_dir);
>  	remove_class_attrs(cls);
>  	subsystem_unregister(&cls->subsys);
>  }

Hm, why is this not reproducable for me then without this patch?

Very strange, I'll dig into it some more this evening, gotta go do
family stuff for the rest of the day...

thanks,

greg k-h

  reply	other threads:[~2006-11-20 20:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-20 17:14 kobject_add failed with -EEXIST Jiri Slaby
2006-11-20 17:27 ` Greg KH
2006-11-20 17:31   ` Jiri Slaby
2006-11-20 17:52     ` Greg KH
2006-11-21 10:49       ` Jiri Slaby
     [not found]       ` <4af2d03a0611241620h657de9b8jfb9310e19f68f426@mail.gmail.com>
2006-11-25  0:30         ` Fwd: " Jiri Slaby
2006-11-20 17:31 ` Greg KH
2006-11-20 17:42   ` Oliver Neukum
2006-11-20 17:47     ` Jiri Slaby
2006-11-20 18:15       ` Jiri Slaby
2006-11-20 18:23 ` Akinobu Mita
2006-11-20 18:56   ` Jiri Slaby
2006-11-20 19:53     ` [PATCH] driver core: delete virtual directory on class_unregister() Akinobu Mita
2006-11-20 20:34       ` Greg KH [this message]
2006-11-21  9:58         ` Akinobu Mita
2006-11-21 15:09           ` Cornelia Huck
2006-11-25  8:58 ` kobject_add failed with -EEXIST markus reichelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061120203440.GA5458@suse.de \
    --to=gregkh@suse.de \
    --cc=akinobu.mita@gmail.com \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox