From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966733AbWKTVGp (ORCPT ); Mon, 20 Nov 2006 16:06:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S966734AbWKTVGp (ORCPT ); Mon, 20 Nov 2006 16:06:45 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:39948 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S966727AbWKTVGo (ORCPT ); Mon, 20 Nov 2006 16:06:44 -0500 Date: Mon, 20 Nov 2006 22:06:43 +0100 From: Adrian Bunk To: Andrew Morton Cc: Bob Moore , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [2.6 patch] drivers/acpi/osl.c: fix a NULL check Message-ID: <20061120210643.GA31879@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org This patch fixes a non-working NULL check introduced by commit b229cf92eee616c7cb5ad8cdb35a19b119f00bc8. Spotted by the Coverity checker. Signed-off-by: Adrian Bunk --- This patch was already sent on: - 15 Aug 2006 --- linux-2.6.18-rc4-mm1/drivers/acpi/osl.c.old 2006-08-15 00:43:30.000000000 +0200 +++ linux-2.6.18-rc4-mm1/drivers/acpi/osl.c 2006-08-15 00:43:55.000000000 +0200 @@ -1030,7 +1030,7 @@ acpi_os_create_cache(char *name, u16 size, u16 depth, acpi_cache_t ** cache) { *cache = kmem_cache_create(name, size, 0, 0, NULL, NULL); - if (cache == NULL) + if (*cache == NULL) return AE_ERROR; else return AE_OK;