public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: d binderman <dcb314@hotmail.com>, ak@suse.de
Cc: Linux-Kernel@vger.kernel.org, discuss@x86-64.org, mingo@redhat.com
Subject: [2.6 patch] x86_64 __setup_APIC_LVTT(): remove unused variable
Date: Tue, 21 Nov 2006 21:20:46 +0100	[thread overview]
Message-ID: <20061121202046.GL5200@stusta.de> (raw)
In-Reply-To: <BAY107-F214E963C5A93489762562E9CEC0@phx.gbl>

On Tue, Nov 21, 2006 at 07:46:46PM +0000, d binderman wrote:
> 
> Hello there,
> 
> I just tried to compile Linux kernel 2.6.18.3 with the Intel C
> C compiler.
> 
> The compiler said
> 
> arch/x86_64/kernel/apic.c(701): remark #593: variable "ver" was set but 
> never used
> 
> The source code is
> 
>    unsigned int lvtt_value, tmp_value, ver;
> 
> I have checked the source code and I agree with the compiler.
> Suggest delete local variable.

Thanks for your report, patch below.

> Regards
> 
> David Binderman

cu
Adrian


<--  snip  -->


This patch removes a variable that whose usage was removed some time ago 
by Andi.

Spotted by the Intel C compiler.

Reported by David Binderman.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.19-rc5-mm2/arch/x86_64/kernel/apic.c.old	2006-11-21 21:17:03.000000000 +0100
+++ linux-2.6.19-rc5-mm2/arch/x86_64/kernel/apic.c	2006-11-21 21:17:16.000000000 +0100
@@ -722,10 +722,9 @@
 
 static void __setup_APIC_LVTT(unsigned int clocks)
 {
-	unsigned int lvtt_value, tmp_value, ver;
+	unsigned int lvtt_value, tmp_value;
 	int cpu = smp_processor_id();
 
-	ver = GET_APIC_VERSION(apic_read(APIC_LVR));
 	lvtt_value = APIC_LVT_TIMER_PERIODIC | LOCAL_TIMER_VECTOR;
 
 	if (cpu_isset(cpu, timer_interrupt_broadcast_ipi_mask))


  parent reply	other threads:[~2006-11-21 20:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-21 19:46 arch/x86_64/kernel/apic.c(701): remark #593: variable "ver" was set but never us d binderman
2006-11-21 20:18 ` David Rientjes
2006-11-21 20:22   ` Andi Kleen
2006-11-21 20:20 ` Adrian Bunk [this message]
2006-11-21 20:23   ` [2.6 patch] x86_64 __setup_APIC_LVTT(): remove unused variable Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061121202046.GL5200@stusta.de \
    --to=bunk@stusta.de \
    --cc=Linux-Kernel@vger.kernel.org \
    --cc=ak@suse.de \
    --cc=dcb314@hotmail.com \
    --cc=discuss@x86-64.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox