* Re: arch/x86_64/kernel/apic.c(701): remark #593: variable "ver" was set but never us
2006-11-21 19:46 arch/x86_64/kernel/apic.c(701): remark #593: variable "ver" was set but never us d binderman
@ 2006-11-21 20:18 ` David Rientjes
2006-11-21 20:22 ` Andi Kleen
2006-11-21 20:20 ` [2.6 patch] x86_64 __setup_APIC_LVTT(): remove unused variable Adrian Bunk
1 sibling, 1 reply; 5+ messages in thread
From: David Rientjes @ 2006-11-21 20:18 UTC (permalink / raw)
To: d binderman; +Cc: Andi Kleen, Ingo Molnar, linux-kernel
Remove unused GET_APIC_VERSION call from clear_local_APIC() and
__setup_APIC_LVTT().
Reported by D Binderman <dcb314@hotmail.com>.
Cc: Andi Kleen <ak@suse.de>
Cc: Ingo Molnar <mingo@redhat.com>
Signed-off-by: David Rientjes <rientjes@cs.washington.edu>
---
arch/x86_64/kernel/apic.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/arch/x86_64/kernel/apic.c b/arch/x86_64/kernel/apic.c
index 4d9d5ed..96743aa 100644
--- a/arch/x86_64/kernel/apic.c
+++ b/arch/x86_64/kernel/apic.c
@@ -133,7 +133,6 @@ void clear_local_APIC(void)
apic_write(APIC_LVTERR, APIC_LVT_MASKED);
if (maxlvt >= 4)
apic_write(APIC_LVTPC, APIC_LVT_MASKED);
- v = GET_APIC_VERSION(apic_read(APIC_LVR));
apic_write(APIC_ESR, 0);
apic_read(APIC_ESR);
}
@@ -644,10 +643,9 @@ #define APIC_DIVISOR 16
static void __setup_APIC_LVTT(unsigned int clocks)
{
- unsigned int lvtt_value, tmp_value, ver;
+ unsigned int lvtt_value, tmp_value;
int cpu = smp_processor_id();
- ver = GET_APIC_VERSION(apic_read(APIC_LVR));
lvtt_value = APIC_LVT_TIMER_PERIODIC | LOCAL_TIMER_VECTOR;
if (cpu_isset(cpu, timer_interrupt_broadcast_ipi_mask))
^ permalink raw reply related [flat|nested] 5+ messages in thread* [2.6 patch] x86_64 __setup_APIC_LVTT(): remove unused variable
2006-11-21 19:46 arch/x86_64/kernel/apic.c(701): remark #593: variable "ver" was set but never us d binderman
2006-11-21 20:18 ` David Rientjes
@ 2006-11-21 20:20 ` Adrian Bunk
2006-11-21 20:23 ` Andi Kleen
1 sibling, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2006-11-21 20:20 UTC (permalink / raw)
To: d binderman, ak; +Cc: Linux-Kernel, discuss, mingo
On Tue, Nov 21, 2006 at 07:46:46PM +0000, d binderman wrote:
>
> Hello there,
>
> I just tried to compile Linux kernel 2.6.18.3 with the Intel C
> C compiler.
>
> The compiler said
>
> arch/x86_64/kernel/apic.c(701): remark #593: variable "ver" was set but
> never used
>
> The source code is
>
> unsigned int lvtt_value, tmp_value, ver;
>
> I have checked the source code and I agree with the compiler.
> Suggest delete local variable.
Thanks for your report, patch below.
> Regards
>
> David Binderman
cu
Adrian
<-- snip -->
This patch removes a variable that whose usage was removed some time ago
by Andi.
Spotted by the Intel C compiler.
Reported by David Binderman.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.19-rc5-mm2/arch/x86_64/kernel/apic.c.old 2006-11-21 21:17:03.000000000 +0100
+++ linux-2.6.19-rc5-mm2/arch/x86_64/kernel/apic.c 2006-11-21 21:17:16.000000000 +0100
@@ -722,10 +722,9 @@
static void __setup_APIC_LVTT(unsigned int clocks)
{
- unsigned int lvtt_value, tmp_value, ver;
+ unsigned int lvtt_value, tmp_value;
int cpu = smp_processor_id();
- ver = GET_APIC_VERSION(apic_read(APIC_LVR));
lvtt_value = APIC_LVT_TIMER_PERIODIC | LOCAL_TIMER_VECTOR;
if (cpu_isset(cpu, timer_interrupt_broadcast_ipi_mask))
^ permalink raw reply [flat|nested] 5+ messages in thread