* [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION
@ 2006-01-12 10:51 Adrian Bunk
2006-01-12 21:52 ` Sam Ravnborg
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2006-01-12 10:51 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Matthew Wilcox, grundler, parisc-linux, linux-kernel
This patch removes the usage of GCC_VERSION from arch/parisc/Makefile.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.15-mm3-hppa/arch/parisc/Makefile.old 2006-01-12 03:11:45.000000000 +0100
+++ linux-2.6.15-mm3-hppa/arch/parisc/Makefile 2006-01-12 03:12:35.000000000 +0100
@@ -35,12 +35,8 @@
OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
-GCC_VERSION := $(call cc-version)
-ifneq ($(shell if [ -z $(GCC_VERSION) ] ; then echo "bad"; fi ;),)
-$(error Sorry, couldn't find ($(cc-version)).)
-endif
-ifneq ($(shell if [ $(GCC_VERSION) -lt 0303 ] ; then echo "bad"; fi ;),)
-$(error Sorry, your compiler is too old ($(GCC_VERSION)). GCC v3.3 or above is required.)
+ifneq ($(shell if [ $(call cc-version) -lt 0303 ] ; then echo "bad"; fi ;),)
+$(error Sorry, your compiler is too old. GCC v3.3 or above is required.)
endif
cflags-y := -pipe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION
2006-01-12 10:51 Adrian Bunk
@ 2006-01-12 21:52 ` Sam Ravnborg
0 siblings, 0 replies; 6+ messages in thread
From: Sam Ravnborg @ 2006-01-12 21:52 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Matthew Wilcox, grundler, parisc-linux, linux-kernel
On Thu, Jan 12, 2006 at 11:51:57AM +0100, Adrian Bunk wrote:
> This patch removes the usage of GCC_VERSION from arch/parisc/Makefile.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
I assume the parisc people will take this one.
Sam
>
> --- linux-2.6.15-mm3-hppa/arch/parisc/Makefile.old 2006-01-12 03:11:45.000000000 +0100
> +++ linux-2.6.15-mm3-hppa/arch/parisc/Makefile 2006-01-12 03:12:35.000000000 +0100
> @@ -35,12 +35,8 @@
>
> OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
>
> -GCC_VERSION := $(call cc-version)
> -ifneq ($(shell if [ -z $(GCC_VERSION) ] ; then echo "bad"; fi ;),)
> -$(error Sorry, couldn't find ($(cc-version)).)
> -endif
> -ifneq ($(shell if [ $(GCC_VERSION) -lt 0303 ] ; then echo "bad"; fi ;),)
> -$(error Sorry, your compiler is too old ($(GCC_VERSION)). GCC v3.3 or above is required.)
> +ifneq ($(shell if [ $(call cc-version) -lt 0303 ] ; then echo "bad"; fi ;),)
> +$(error Sorry, your compiler is too old. GCC v3.3 or above is required.)
> endif
>
> cflags-y := -pipe
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION
@ 2006-08-19 17:19 Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2006-08-19 17:19 UTC (permalink / raw)
To: Sam Ravnborg, Matthew Wilcox, grundler, parisc-linux,
linux-kernel, Kyle McMartin
This patch removes the usage of GCC_VERSION from arch/parisc/Makefile.
There are no functional changes, it simply makes it a bit shorter (and
removes the last instance of GCC_VERSION in the kernel).
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Kyle McMartin <kyle@mcmartin.ca>
---
This patch was already sent on:
- 12 Jan 2006
--- linux-2.6.15-mm3-hppa/arch/parisc/Makefile.old 2006-01-12 03:11:45.000000000 +0100
+++ linux-2.6.15-mm3-hppa/arch/parisc/Makefile 2006-01-12 03:12:35.000000000 +0100
@@ -35,12 +35,8 @@
OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
-GCC_VERSION := $(call cc-version)
-ifneq ($(shell if [ -z $(GCC_VERSION) ] ; then echo "bad"; fi ;),)
-$(error Sorry, couldn't find ($(cc-version)).)
-endif
-ifneq ($(shell if [ $(GCC_VERSION) -lt 0303 ] ; then echo "bad"; fi ;),)
-$(error Sorry, your compiler is too old ($(GCC_VERSION)). GCC v3.3 or above is required.)
+ifneq ($(shell if [ $(call cc-version) -lt 0303 ] ; then echo "bad"; fi ;),)
+$(error Sorry, your compiler is too old. GCC v3.3 or above is required.)
endif
cflags-y := -pipe
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION
@ 2006-11-21 20:37 Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2006-11-21 20:37 UTC (permalink / raw)
To: Andrew Morton
Cc: Sam Ravnborg, Matthew Wilcox, grundler, parisc-linux,
linux-kernel, Kyle McMartin
This patch removes the usage of GCC_VERSION from arch/parisc/Makefile.
There are no functional changes, it simply makes it a bit shorter (and
removes the last instance of GCC_VERSION in the kernel).
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Kyle McMartin <kyle@mcmartin.ca>
---
This patch was already sent on:
- 19 Aug 2006
- 12 Jan 2006
--- linux-2.6.15-mm3-hppa/arch/parisc/Makefile.old 2006-01-12 03:11:45.000000000 +0100
+++ linux-2.6.15-mm3-hppa/arch/parisc/Makefile 2006-01-12 03:12:35.000000000 +0100
@@ -35,12 +35,8 @@
OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
-GCC_VERSION := $(call cc-version)
-ifneq ($(shell if [ -z $(GCC_VERSION) ] ; then echo "bad"; fi ;),)
-$(error Sorry, couldn't find ($(cc-version)).)
-endif
-ifneq ($(shell if [ $(GCC_VERSION) -lt 0303 ] ; then echo "bad"; fi ;),)
-$(error Sorry, your compiler is too old ($(GCC_VERSION)). GCC v3.3 or above is required.)
+ifneq ($(shell if [ $(call cc-version) -lt 0303 ] ; then echo "bad"; fi ;),)
+$(error Sorry, your compiler is too old. GCC v3.3 or above is required.)
endif
cflags-y := -pipe
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION
@ 2006-12-01 11:49 Adrian Bunk
2006-12-01 18:23 ` Grant Grundler
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2006-12-01 11:49 UTC (permalink / raw)
To: Andrew Morton
Cc: Sam Ravnborg, Matthew Wilcox, grundler, parisc-linux,
linux-kernel, Kyle McMartin
This patch removes the usage of GCC_VERSION from arch/parisc/Makefile.
There are no functional changes, it simply makes it a bit shorter (and
removes the last instance of GCC_VERSION in the kernel).
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Kyle McMartin <kyle@mcmartin.ca>
---
This patch was already sent on:
- 21 Nov 2006
- 19 Aug 2006
- 12 Jan 2006
--- linux-2.6.15-mm3-hppa/arch/parisc/Makefile.old 2006-01-12 03:11:45.000000000 +0100
+++ linux-2.6.15-mm3-hppa/arch/parisc/Makefile 2006-01-12 03:12:35.000000000 +0100
@@ -35,12 +35,8 @@
OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
-GCC_VERSION := $(call cc-version)
-ifneq ($(shell if [ -z $(GCC_VERSION) ] ; then echo "bad"; fi ;),)
-$(error Sorry, couldn't find ($(cc-version)).)
-endif
-ifneq ($(shell if [ $(GCC_VERSION) -lt 0303 ] ; then echo "bad"; fi ;),)
-$(error Sorry, your compiler is too old ($(GCC_VERSION)). GCC v3.3 or above is required.)
+ifneq ($(shell if [ $(call cc-version) -lt 0303 ] ; then echo "bad"; fi ;),)
+$(error Sorry, your compiler is too old. GCC v3.3 or above is required.)
endif
cflags-y := -pipe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION
2006-12-01 11:49 Adrian Bunk
@ 2006-12-01 18:23 ` Grant Grundler
0 siblings, 0 replies; 6+ messages in thread
From: Grant Grundler @ 2006-12-01 18:23 UTC (permalink / raw)
To: Adrian Bunk
Cc: Andrew Morton, Sam Ravnborg, Matthew Wilcox, grundler,
parisc-linux, linux-kernel, Kyle McMartin
On Fri, Dec 01, 2006 at 12:49:08PM +0100, Adrian Bunk wrote:
> This patch removes the usage of GCC_VERSION from arch/parisc/Makefile.
>
> There are no functional changes, it simply makes it a bit shorter (and
> removes the last instance of GCC_VERSION in the kernel).
Thanks!
I've committed a variant of this to git://git.parisc-linux.org/git/linux-2.6.git
I didn't test the failure case - only that it doesn't trigger with
my current gcc 4.x compilers.
I expect Kyle will push parisc tree to linus in the near future.
Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index 9b7e424..760567a 100644
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -35,12 +35,8 @@ FINAL_LD=$(CROSS_COMPILE)ld --warn-commo
OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
-GCC_VERSION := $(call cc-version)
-ifneq ($(shell if [ -z $(GCC_VERSION) ] ; then echo "bad"; fi ;),)
-$(error Sorry, couldn't find ($(cc-version)).)
-endif
-ifneq ($(shell if [ $(GCC_VERSION) -lt 0303 ] ; then echo "bad"; fi ;),)
-$(error Sorry, your compiler is too old ($(GCC_VERSION)). GCC v3.3 or above is required.)
+ifneq ($(call cc-ifversion, -lt, 0303, "bad"),)
+$(error Sorry, GCC v3.3 or above is required.)
endif
cflags-y := -pipe
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-12-01 18:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-21 20:37 [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2006-12-01 11:49 Adrian Bunk
2006-12-01 18:23 ` Grant Grundler
2006-08-19 17:19 Adrian Bunk
2006-01-12 10:51 Adrian Bunk
2006-01-12 21:52 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox