From: Mathieu Desnoyers <compudj@krystal.dyndns.org>
To: Greg KH <greg@kroah.com>
Cc: ltt-dev@shafik.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/5] DebugFS : file/directory creation error handling, 2.6.18
Date: Thu, 23 Nov 2006 03:00:09 -0500 [thread overview]
Message-ID: <20061123080009.GD1703@Krystal> (raw)
In-Reply-To: <20061122052730.GD20836@kroah.com>
Fix error handling of file and directory creation in DebugFS.
The error path should release the file system because no _remove will be called
for this erroneous creation.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -198,13 +198,15 @@
pr_debug("debugfs: creating file '%s'\n",name);
- error = simple_pin_fs(&debug_fs_type, &debugfs_mount, &debugfs_mount_count);
+ error = simple_pin_fs(&debug_fs_type, &debugfs_mount,
+ &debugfs_mount_count);
if (error)
goto exit;
error = debugfs_create_by_name(name, mode, parent, &dentry);
if (error) {
dentry = NULL;
+ simple_release_fs(&debugfs_mount, &debugfs_mount_count);
goto exit;
}
OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2006-11-23 8:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-20 18:18 Debugfs : inotify, multiple calls to debugfs_create_file, remove Mathieu Desnoyers
2006-11-22 5:27 ` Greg KH
2006-11-23 7:47 ` Mathieu Desnoyers
2006-11-23 7:51 ` [PATCH 1/5] DebugFS : inotify create/mkdir support Mathieu Desnoyers
2006-11-24 8:13 ` Greg KH
2006-11-24 13:39 ` Mathieu Desnoyers
2006-11-24 18:45 ` [PATCH 1/5] DebugFS : inotify create/mkdir support, 2.6.19-rc6 Mathieu Desnoyers
2006-11-23 7:52 ` [PATCH 2/5] DebugFS : coding style fixes Mathieu Desnoyers
2006-11-24 18:46 ` [PATCH 2/5] DebugFS : coding style fixes, 2.6.19-rc6 Mathieu Desnoyers
2006-11-23 8:00 ` Mathieu Desnoyers [this message]
2006-11-24 18:48 ` [PATCH 3/5] DebugFS : file/directory creation error handling, 2.6.19-rc6 Mathieu Desnoyers
2006-11-23 8:12 ` [PATCH 4/5] DebugFS : file/directory creation error handling, 2.6.18 Mathieu Desnoyers
2006-11-24 18:50 ` [PATCH 4/5] DebugFS : file/directory creation error handling, 2.6.19-rc6 Mathieu Desnoyers
2006-11-23 8:22 ` [PATCH 5/5] libfs : file/directory removal fix, 2.6.18 Mathieu Desnoyers
2006-11-23 8:50 ` Al Viro
2006-11-23 9:01 ` Al Viro
2006-11-23 17:28 ` Mathieu Desnoyers
2006-11-23 17:25 ` Mathieu Desnoyers
2006-11-23 17:54 ` [PATCH 5/5] DebugFS " Mathieu Desnoyers
2006-11-24 18:51 ` [PATCH 5/5] DebugFS : file/directory removal fix, 2.6.19-rc6 Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061123080009.GD1703@Krystal \
--to=compudj@krystal.dyndns.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ltt-dev@shafik.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox