public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, linux-driver@qlogic.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	James.Bottomley@SteelEye.com
Subject: [-mm patch] make qla2x00_reg_remote_port() static
Date: Fri, 24 Nov 2006 02:46:01 +0100	[thread overview]
Message-ID: <20061124014601.GQ3557@stusta.de> (raw)
In-Reply-To: <20061123021703.8550e37e.akpm@osdl.org>

On Thu, Nov 23, 2006 at 02:17:03AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.19-rc5-mm2:
>...
>  git-scsi-misc.patch
>...
>  git trees
>...

qla2x00_reg_remote_port() can now become static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/scsi/qla2xxx/qla_gbl.h  |    1 
 drivers/scsi/qla2xxx/qla_init.c |   68 ++++++++++++++++----------------
 2 files changed, 34 insertions(+), 35 deletions(-)

--- linux-2.6.19-rc6-mm1/drivers/scsi/qla2xxx/qla_gbl.h.old	2006-11-24 01:18:47.000000000 +0100
+++ linux-2.6.19-rc6-mm1/drivers/scsi/qla2xxx/qla_gbl.h	2006-11-24 01:18:53.000000000 +0100
@@ -45,7 +45,6 @@
 extern int qla2x00_abort_isp(scsi_qla_host_t *);
 
 extern void qla2x00_update_fcport(scsi_qla_host_t *, fc_port_t *);
-extern void qla2x00_reg_remote_port(scsi_qla_host_t *, fc_port_t *);
 
 extern void qla2x00_alloc_fw_dump(scsi_qla_host_t *);
 extern void qla2x00_try_to_stop_firmware(scsi_qla_host_t *);
--- linux-2.6.19-rc6-mm1/drivers/scsi/qla2xxx/qla_init.c.old	2006-11-24 01:19:00.000000000 +0100
+++ linux-2.6.19-rc6-mm1/drivers/scsi/qla2xxx/qla_init.c	2006-11-24 01:20:25.000000000 +0100
@@ -2103,40 +2103,7 @@
 	}
 }
 
-/*
- * qla2x00_update_fcport
- *	Updates device on list.
- *
- * Input:
- *	ha = adapter block pointer.
- *	fcport = port structure pointer.
- *
- * Return:
- *	0  - Success
- *  BIT_0 - error
- *
- * Context:
- *	Kernel context.
- */
-void
-qla2x00_update_fcport(scsi_qla_host_t *ha, fc_port_t *fcport)
-{
-	fcport->ha = ha;
-	fcport->login_retry = 0;
-	fcport->port_login_retry_count = ha->port_down_retry_count *
-	    PORT_RETRY_TIME;
-	atomic_set(&fcport->port_down_timer, ha->port_down_retry_count *
-	    PORT_RETRY_TIME);
-	fcport->flags &= ~FCF_LOGIN_NEEDED;
-
-	qla2x00_iidma_fcport(ha, fcport);
-
-	atomic_set(&fcport->state, FCS_ONLINE);
-
-	qla2x00_reg_remote_port(ha, fcport);
-}
-
-void
+static void
 qla2x00_reg_remote_port(scsi_qla_host_t *ha, fc_port_t *fcport)
 {
 	struct fc_rport_identifiers rport_ids;
@@ -2179,6 +2146,39 @@
 }
 
 /*
+ * qla2x00_update_fcport
+ *	Updates device on list.
+ *
+ * Input:
+ *	ha = adapter block pointer.
+ *	fcport = port structure pointer.
+ *
+ * Return:
+ *	0  - Success
+ *  BIT_0 - error
+ *
+ * Context:
+ *	Kernel context.
+ */
+void
+qla2x00_update_fcport(scsi_qla_host_t *ha, fc_port_t *fcport)
+{
+	fcport->ha = ha;
+	fcport->login_retry = 0;
+	fcport->port_login_retry_count = ha->port_down_retry_count *
+	    PORT_RETRY_TIME;
+	atomic_set(&fcport->port_down_timer, ha->port_down_retry_count *
+	    PORT_RETRY_TIME);
+	fcport->flags &= ~FCF_LOGIN_NEEDED;
+
+	qla2x00_iidma_fcport(ha, fcport);
+
+	atomic_set(&fcport->state, FCS_ONLINE);
+
+	qla2x00_reg_remote_port(ha, fcport);
+}
+
+/*
  * qla2x00_configure_fabric
  *      Setup SNS devices with loop ID's.
  *


  parent reply	other threads:[~2006-11-24  1:46 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-23 10:17 2.6.19-rc6-mm1 Andrew Morton
2006-11-23 10:38 ` 2.6.19-rc6-mm1 Reuben Farrelly
2006-11-23 14:06   ` [PATCH] x86_64: fix build without HOTPLUG_CPU (was Re: 2.6.19-rc6-mm1) Jiri Kosina
2006-11-23 15:08     ` Andi Kleen
2006-11-23 15:17       ` Jiri Kosina
2006-11-23 15:27         ` Andi Kleen
2006-11-23 15:37           ` Jiri Kosina
2006-11-23 16:33             ` Ingo Molnar
2006-11-23 11:23 ` 2.6.19-rc6-mm1 Mariusz Kozlowski
2006-11-23 18:36   ` 2.6.19-rc6-mm1 Andrew Morton
2006-11-23 19:24     ` 2.6.19-rc6-mm1 Mariusz Kozlowski
2006-11-23 20:20     ` 2.6.19-rc6-mm1 Andy Whitcroft
2006-11-23 20:56       ` 2.6.19-rc6-mm1 Andrew Morton
2006-11-24 19:34       ` 2.6.19-rc6-mm1 Matthew Frost
2006-11-23 20:23     ` 2.6.19-rc6-mm1 Benoit Boissinot
2006-11-23 12:22 ` 2.6.19-rc6-mm1 Mariusz Kozlowski
2006-11-23 13:03 ` 2.6.19-rc6-mm1 Andy Whitcroft
2006-11-23 17:26 ` MCORE2 include/asm/module.h:60:2: error: #error unknown processor family [was Re: 2.6.19-rc6-mm1] Mattia Dongili
2006-11-23 23:30 ` 2.6.19-rc6-mm1: no help text for TCP_MD5SIG_DEBUG Adrian Bunk
2006-11-24  1:37   ` David Miller
2006-11-24  0:17 ` 2.6.19-rc6-mm1: drivers/net/chelsio/: unused code Adrian Bunk
2006-11-27 18:24   ` Stephen Hemminger
2006-11-29  7:36     ` Adrian Bunk
2006-11-29  7:47       ` Andrew Morton
2007-02-20  0:02         ` Adrian Bunk
2007-02-20 21:31           ` Stephen Hemminger
2007-02-20 22:06             ` Adrian Bunk
2006-11-24  1:46 ` Adrian Bunk [this message]
2006-11-27 17:22   ` [-mm patch] make qla2x00_reg_remote_port() static Andrew Vasquez
2006-11-24  1:46 ` [-mm patch] make proc_pid_io_accounting() static Adrian Bunk
2006-11-24  1:46 ` [-mm patch] make readahead_debug_level static Adrian Bunk
2006-11-24 16:59 ` [PATCH] efi_limit_regions triggers link failure when CONFIG_EFI is not defined Andy Whitcroft
2006-11-24 17:05   ` Andi Kleen
2006-11-24 17:24     ` Andy Whitcroft
2006-11-24 17:33       ` Andi Kleen
2006-11-24 21:30         ` Andrew Morton
2006-11-26  2:13     ` Matthew Frost
2006-11-24 17:58 ` [PATCH] x86_64 vsyscall fails to compile when CONFIG_HOTPLUG_CPU is disabled Andy Whitcroft
2006-11-24 18:03   ` Jiri Kosina
2006-11-24 19:11   ` Andi Kleen
2006-11-24 21:58 ` [-mm patch] net/: possible cleanups Adrian Bunk
2006-12-01  1:28   ` David Miller
2006-11-25 19:15 ` [-mm patch] include/linux/bug.h must always #include <linux/module.h> Adrian Bunk
2006-11-25 19:17 ` [-mm patch] fs/stack.c should #include <linux/fs_stack.h> Adrian Bunk
2006-11-25 19:57   ` Josef Sipek
2006-11-25 19:21 ` [-mm patch] fs/reiser4/: more possible cleanups Adrian Bunk
2006-11-25 19:48 ` 2.6.19-rc6-mm1 -- sched-improve-migration-accuracy.patch slows boot Don Mullis
2006-11-26  6:24   ` Mike Galbraith
2006-11-27  1:38     ` Don Mullis
2006-11-27 10:16       ` Ingo Molnar
2006-11-28 18:47         ` Don Mullis
2006-11-27 10:50       ` [patch] " Mike Galbraith
2006-11-27 17:17         ` Don Mullis
2006-11-27 18:27           ` Mike Galbraith
2006-11-26  5:40 ` [-mm patch] sound/soc/soc-dapm.c: make 4 functions static Adrian Bunk
2006-11-27  4:21 ` [PATCH] paravirt reorder functions to avoid unspecified behaviour Andy Whitcroft
2006-11-27 11:13   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061124014601.GQ3557@stusta.de \
    --to=bunk@stusta.de \
    --cc=James.Bottomley@SteelEye.com \
    --cc=akpm@osdl.org \
    --cc=linux-driver@qlogic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox