Re: 2.6.19-rc6-mm1: drivers/net/chelsio/: unused code

Adrian Bunk
2007-02-20T00:03:19Z

On Tue, Nov 28, 2006 at 11:47:19PM -0800, Andrew Morton wrote:
> On Wed, 29 Nov 2006 08:36:09 +0100
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > On Mon, Nov 27, 2006 at 10:24:55AM -0800, Stephen Hemminger wrote:
> > > On Fri, 24 Nov 2006 01:17:31 +0100
> > > Adrian Bunk <bunk@stusta.de> wrote:
> > >
> > > > On Thu, Nov 23, 2006 at 02:17:03AM -0800, Andrew Morton wrote:
> > > > >...
> > > > > Changes since 2.6.19-rc5-mm2:
> > > > >...
> > > > > +chelsio-22-driver.patch
> > > > >...
> > > > > netdev updates
> > > >
> > > > It is suspicious that the following newly added code is completely unused:
> > > > drivers/net/chelsio/ixf1010.o
> > > > t1_ixf1010_ops
> > > > drivers/net/chelsio/mac.o
> > > > t1_chelsio_mac_ops
> > > > drivers/net/chelsio/vsc8244.o
> > > > t1_vsc8244_ops
> > > >
> > > > cu
> > > > Adrian
> > > >
> > >
> > > All that is gone in later version. I reposted new patches
> > > after -mm2 was done.
> >
> > It seems these patches didn't make it into 2.6.19-rc6-mm2 ?
>
> I dropped that patch and picked up Francois's tree instead.

These structs are still both present and unused as of 2.6.20-mm1.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed