From: Ralf Baechle <ralf@linux-mips.org>
To: Willy Tarreau <w@1wt.eu>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
Andreas Koensgen <ajk@iehk.rwth-aachen.de>,
linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] 6pack: fix "&= !" typo
Date: Fri, 24 Nov 2006 21:42:18 +0000 [thread overview]
Message-ID: <20061124214218.GA13168@linux-mips.org> (raw)
In-Reply-To: <20061124212306.GA1736@1wt.eu>
On Fri, Nov 24, 2006 at 10:23:06PM +0100, Willy Tarreau wrote:
> One more reason to perform more code reviews helped with automated tools.
> We found this one and the rio's one while discussing with Jean Delvare
> about such bugs, and firing a random grep to illustrate how easy it could
> be to spot bugs similar to Alexey's "&&" instead of "&" ...
>
> I think that we should at least take a look at all lines in the pre-processed
> code having both '!' and '&' on the same line. There are a lot of them, but
> divided by a sufficient number of volunteers, we might catch a bunch of them.
>
> BTW, has anyone a good idea on how to make gcc dump the preprocessed files
> for everything it builds ? I mean, just by changing some variables in the
> Makefile.
It seems to might be about to re-invent sparse which is probably the
right framework for such semantic tests.
Ralf
prev parent reply other threads:[~2006-11-24 21:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 22:58 [PATCH] rio: typo in bitwise AND expression Willy Tarreau
2006-11-23 14:11 ` Patrick vd Lageweg
2006-11-23 21:15 ` Willy Tarreau
2006-11-24 18:58 ` [PATCH] 6pack: fix "&= !" typo Alexey Dobriyan
2006-11-24 20:21 ` Ralf Baechle
2006-11-24 21:23 ` Willy Tarreau
2006-11-24 21:42 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061124214218.GA13168@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=adobriyan@gmail.com \
--cc=ajk@iehk.rwth-aachen.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox