From: Jeff Dike <jdike@addtoit.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, blaisorblade@yahoo.it
Subject: Re: + uml-make-execvp-safe-for-our-usage.patch added to -mm tree
Date: Fri, 24 Nov 2006 18:11:12 -0500 [thread overview]
Message-ID: <20061124231112.GA5781@ccure.user-mode-linux.org> (raw)
In-Reply-To: <20061124134621.be9835e7.akpm@osdl.org>
On Fri, Nov 24, 2006 at 01:46:21PM -0800, Andrew Morton wrote:
> OK. Is it needed for 2.6.19?
It fixes bugs, so I would say yes.
> Also, I'm still sitting on the below. I have a note that you nacked it,
> but I forget why.
I nacked it mostly based on the changelog, which turned out to be
incorrect. The substance of the change I think is OK, except that it
looks like stddef (according to the C standard - 4.1.5) , not
linux/types is the official way to get size_t. I'll send a follow-up
patch to fix that.
I would hold this patch until after 2.6.19.
Jeff
--
Work email - jdike at linux dot intel dot com
prev parent reply other threads:[~2006-11-24 23:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200610180014.k9I0EZ1J012332@shell0.pdx.osdl.net>
2006-11-24 19:50 ` + uml-make-execvp-safe-for-our-usage.patch added to -mm tree Jeff Dike
2006-11-24 21:46 ` Andrew Morton
2006-11-24 23:11 ` Jeff Dike [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061124231112.GA5781@ccure.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@osdl.org \
--cc=blaisorblade@yahoo.it \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox