From: Willy Tarreau <w@1wt.eu>
To: shaggy@austin.ibm.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH-2.4] jfs: incorrect use of "&&" instead of "&"
Date: Sat, 25 Nov 2006 22:24:40 +0100 [thread overview]
Message-ID: <20061125212440.GA5930@1wt.eu> (raw)
Hi Dave,
I'm about to merge this fix in 2.4. It's already in 2.6 BTW.
Do you have any objection ?
Thanks in advance,
Willy
>From b14cb91c6621908f8e957aad5a85d6c41b31dfea Mon Sep 17 00:00:00 2001
From: Willy Tarreau <w@1wt.eu>
Date: Sat, 25 Nov 2006 21:57:26 +0100
Subject: [PATCH] jfs: incorrect use of "&&" instead of "&"
in jfs_txnmgr, the use of "tblk->flag && COMMIT_DELETE" in a
if() condition is obviously wrong. This bug has already been
fixed in 2.6.
Signed-off-by: Willy Tarreau <w@1wt.eu>
---
fs/jfs/jfs_txnmgr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c
index 62e6493..4e6a280 100644
--- a/fs/jfs/jfs_txnmgr.c
+++ b/fs/jfs/jfs_txnmgr.c
@@ -1175,7 +1175,7 @@ int txCommit(tid_t tid, /* transaction
jfs_ip = JFS_IP(ip);
if (test_and_clear_cflag(COMMIT_Syncdata, ip) &&
- ((tblk->flag && COMMIT_DELETE) == 0))
+ ((tblk->flag & COMMIT_DELETE) == 0))
fsync_inode_data_buffers(ip);
/*
--
1.4.2.4
next reply other threads:[~2006-11-25 20:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-25 21:24 Willy Tarreau [this message]
2006-11-25 20:43 ` [PATCH-2.4] jfs: incorrect use of "&&" instead of "&" Dave Kleikamp
2006-11-25 21:38 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061125212440.GA5930@1wt.eu \
--to=w@1wt.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=shaggy@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox