Re: [patch] PM: suspend/resume debugging should depend on SOFTWARE_SUSPEND

Pavel Machek
2006-11-19T08:29:42Z

Hi!

> When doing 'make oldconfig' we should ask about suspend/resume
> debug features when SOFTWARE_SUSPEND is not enabled.

These are suspend-to-ram debugging features, mostly, so no, they
should not depend on software suspend.

NAK.

> Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
>
> --- 2.6.19-rc6-32.orig/kernel/power/Kconfig
> +++ 2.6.19-rc6-32/kernel/power/Kconfig
> @@ -38,7 +38,7 @@ config PM_DEBUG
>
> config DISABLE_CONSOLE_SUSPEND
> bool "Keep console(s) enabled during suspend/resume (DANGEROUS)"
> - depends on PM && PM_DEBUG
> + depends on PM_DEBUG && SOFTWARE_SUSPEND
> default n
> ---help---
> This option turns off the console suspend mechanism that prevents
> @@ -49,7 +49,7 @@ config DISABLE_CONSOLE_SUSPEND
>
> config PM_TRACE
> bool "Suspend/resume event tracing"
> - depends on PM && PM_DEBUG && X86_32 && EXPERIMENTAL
> + depends on PM_DEBUG && SOFTWARE_SUSPEND && X86_32 && EXPERIMENTAL
> default n
> ---help---
> This enables some cheesy code to save the last PM event point in the

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html