From: Ralf Baechle <ralf@linux-mips.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
Kyle McMartin <kyle@parisc-linux.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: Build breakage ...
Date: Mon, 27 Nov 2006 16:43:32 +0000 [thread overview]
Message-ID: <20061127164332.GA26389@linux-mips.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0611261627260.30076@woody.osdl.org>
On Sun, Nov 26, 2006 at 04:29:00PM -0800, Linus Torvalds wrote:
> > > Ralf, Russell, does this work for you guys?
> >
> > Not at all. It creates even more problems for me, with this circular
> > dependency:
>
> Ok. I just reverted it then.
>
> Pls verify that this is all good, and I didn't mess anything up due to the
> manual conflict resolution.
Thanks, 2ea5814472c3c910aed5c5b60f1f3b1000e353f1 builds again for MIPS.
If you deciede to put the patch back in after 2.6.19 I'm considering to
replace the local_irq_{save,restore} calls in the various atomic operations
in <asm/{atomic,bitops,system}.h with their raw_* equivalents.
What I dislike about Alexey's patch is that is finally tries to cast
unsigned long as the data type for the flags into stone. The natural
data type to use on MIPS and several other architectures is a 32-bit
integer - or just a single bit on a stingy day ;-). Time for flags_t
maybe?
Ralf
next prev parent reply other threads:[~2006-11-27 16:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-26 22:49 Build breakage Ralf Baechle
2006-11-26 23:05 ` Russell King
2006-11-26 23:09 ` Russell King
2006-11-26 23:06 ` Linus Torvalds
2006-11-26 23:12 ` Linus Torvalds
2006-11-26 23:21 ` Russell King
2006-11-27 0:29 ` Linus Torvalds
2006-11-27 0:41 ` Russell King
2006-11-27 16:43 ` Ralf Baechle [this message]
2006-11-27 19:56 ` Alexey Dobriyan
2006-11-27 0:08 ` Ralf Baechle
2006-11-26 23:47 ` Kyle McMartin
2006-11-26 23:56 ` [PARISC] Fix incorrent type of flags in <asm/semaphore.h> Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061127164332.GA26389@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=adobriyan@gmail.com \
--cc=kyle@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox