public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor@insightbb.com>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: juanslayton@dslextreme.com,
	linux-hotplug-devel@lists.sourceforge.net,
	Vojtech Pavlik <vojtech@suse.cz>,
	linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [RFC/PATCH] Uncap max number of evdev devices [was: Re: need more events]
Date: Mon, 27 Nov 2006 22:45:19 -0500	[thread overview]
Message-ID: <200611272245.21645.dtor@insightbb.com> (raw)
In-Reply-To: <20061127185651.GC10879@austin.ibm.com>

On Monday 27 November 2006 13:56, Linas Vepstas wrote:
> On Fri, Nov 24, 2006 at 05:09:52PM -0800, juanslayton@dslextreme.com wrote:
> > 
> >      The object is to poll 20 usb keyboards in an elementary school
> > classroom, each of which generates 2
> > events (one keyboard and one mouse).  The stock kernel maxes out at event
> > 31, leaving me 4
> > keyboards short.
> >      I thought to fix this by changing the definition of EVDEV_MINORS
> > (line 12, evdev.c) from 32 to 64.  It almost worked.  The extra
> > events showed up in /dev/input/* and /proc/bus/input/devices.
> > However, attempting to access the new events in the application
> > program only yields a segmentation fault.  Obviously I've got to change
> > something else.
> 
> The problem is in input_register_handler() in drivers/input/input.c
> which does things like 
> if (input_table[handler->minor >> 5])
>  and 
> input_table[handler->minor >> 5] = handler;
> 
> which implicitly makes 32 the max. 
> 
> The kernel path below removes this limitation. Does it fix your problem?
> 

This makes /dev/input/js32-63 take over /dev/input/mouse0-31 which is
contrary to what Documentation/devices.txt says and therefore not a good
idea for the mainline.

I am planning to convert input core to cdevs and that table will go away
completely and then it can be discussed how to extend range of input
devices (probably by going beyond 256 minors?).

-- 
Dmitry

      reply	other threads:[~2006-11-28  3:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <7c50a14e8ca157b0abe20a.20061124170952.whnafynlgba@www.dslextreme.com>
2006-11-27 18:56 ` [RFC/PATCH] Uncap max number of evdev devices [was: Re: need more events] Linas Vepstas
2006-11-28  3:45   ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611272245.21645.dtor@insightbb.com \
    --to=dtor@insightbb.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=juanslayton@dslextreme.com \
    --cc=linas@austin.ibm.com \
    --cc=linux-hotplug-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox