[RFC: 2.6 patch] don't export device IDs to userspace

[RFC: 2.6 patch] don't export device IDs to userspace

[Adrian Bunk]

I don't see any good reason for exporting device IDs to userspace.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 include/linux/Kbuild |    2 --
 include/linux/pci.h  |    6 +++---
 2 files changed, 3 insertions(+), 5 deletions(-)

--- linux-2.6.19-rc6-mm1/include/linux/Kbuild.old	2006-11-27 22:19:55.000000000 +0100
+++ linux-2.6.19-rc6-mm1/include/linux/Kbuild	2006-11-27 22:24:53.000000000 +0100
@@ -122,7 +122,6 @@
 header-y += nfs_mount.h
 header-y += oom.h
 header-y += param.h
-header-y += pci_ids.h
 header-y += pci_regs.h
 header-y += personality.h
 header-y += pfkeyv2.h
@@ -165,7 +164,6 @@
 header-y += wireless.h
 header-y += xattr.h
 header-y += x25.h
-header-y += zorro_ids.h
 
 unifdef-y += acct.h
 unifdef-y += adb.h
--- linux-2.6.19-rc6-mm1/include/linux/pci.h.old	2006-11-27 23:11:11.000000000 +0100
+++ linux-2.6.19-rc6-mm1/include/linux/pci.h	2006-11-27 23:11:47.000000000 +0100
@@ -20,9 +20,6 @@
 /* Include the pci register defines */
 #include <linux/pci_regs.h>
 
-/* Include the ID list */
-#include <linux/pci_ids.h>
-
 /*
  * The PCI interface treats multi-function devices as independent
  * devices.  The slot/function address of each device is encoded
@@ -53,6 +50,9 @@
 #include <linux/errno.h>
 #include <linux/device.h>
 
+/* Include the ID list */
+#include <linux/pci_ids.h>
+
 /* File state for mmap()s on /proc/bus/pci/X/Y */
 enum pci_mmap_state {
 	pci_mmap_io,

Re: [RFC: 2.6 patch] don't export device IDs to userspace

[Greg KH]

On Tue, Nov 28, 2006 at 02:28:34AM +0100, Adrian Bunk wrote:
> I don't see any good reason for exporting device IDs to userspace.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

No objection from me:
	Acked-by: Greg Kroah-Hartman <gregkh@suse.de>