From: Akinobu Mita <akinobu.mita@gmail.com>
To: Mark Gross <mgross@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Sebastien Bouchard <sebastien.bouchard@ca.kontron.com>,
akpm@osdl.org
Subject: Re: [PATCH] tlclk: fix platform_device_register_simple() error check
Date: Tue, 28 Nov 2006 15:08:30 +0900 [thread overview]
Message-ID: <20061128060830.GA28689@APFDCB5C> (raw)
In-Reply-To: <20061127203452.GA12279@linux.intel.com>
On Mon, Nov 27, 2006 at 12:34:52PM -0800, Mark Gross wrote:
> >
> > tlclk_device = platform_device_register_simple("telco_clock",
> > -1, NULL, 0);
> > - if (!tlclk_device) {
> > + if (IS_ERR(tlclk_device)) {
> ok
>
> > printk(KERN_ERR "tlclk: platform_device_register failed.\n");
> > - ret = -EBUSY;
> > + ret = PTR_ERR(tlclk_device);
>
> I don't know about this but I could be wrong. Please convince me.
We expect platform_device_register_simple() returns proper errno as pointer
when it fails.
next prev parent reply other threads:[~2006-11-28 6:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 18:41 [PATCH] tlclk: fix platform_device_register_simple() error check Akinobu Mita
2006-11-27 20:34 ` Mark Gross
2006-11-27 20:46 ` Mark Gross
2006-11-28 6:08 ` Akinobu Mita [this message]
2006-11-29 21:17 ` Mark Gross
2006-12-02 4:03 ` Akinobu Mita
2006-12-05 18:25 ` Mark Gross
2007-01-03 16:56 ` Mark Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061128060830.GA28689@APFDCB5C \
--to=akinobu.mita@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=sebastien.bouchard@ca.kontron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox