From: Andrew Morton <akpm@osdl.org>
To: Don Mullis <dwm@meer.net>
Cc: lkml <linux-kernel@vger.kernel.org>,
Akinobu Mita <mita@miraclelinux.com>
Subject: Re: [PATCH 1/2 -mm] fault-injection: safer defaults, trivial optimization, cleanup
Date: Tue, 28 Nov 2006 13:37:54 -0800 [thread overview]
Message-ID: <20061128133754.bad99ddb.akpm@osdl.org> (raw)
In-Reply-To: <1164699866.2894.88.camel@localhost.localdomain>
On Mon, 27 Nov 2006 23:44:26 -0800
Don Mullis <dwm@meer.net> wrote:
> Set /debug/fail*/* defaults supposed most likely to please a new user.
> Clamp /debug/fail*/stacktrace-depth to MAX_STACK_TRACE_DEPTH.
>
> In should_fail(), move stack-unwinding test past cheaper tests (performance
> gain not quantified). Simplify logic; eliminate goto.
> Use bool/true/false consistently.
>
> Correct and disambiguate documentation.
We'd prefer one-patch-per-concept, please. This all sounds like about
six patches.
We _could_ merge this patch as-is, but it means that when this stuff
finally hits mainline it would go in as a nice sequence of logical patches,
followed by a random thing which is splattered all over all the preceding
patches.
next prev parent reply other threads:[~2006-11-28 21:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-28 7:44 [PATCH 1/2 -mm] fault-injection: safer defaults, trivial optimization, cleanup Don Mullis
2006-11-28 7:51 ` [PATCH 2/2 -mm] fault-injection: lightweight code-coverage maximizer Don Mullis
2006-11-28 9:18 ` Akinobu Mita
2006-11-28 20:14 ` Don Mullis
2006-11-29 2:37 ` Akinobu Mita
2006-11-29 19:47 ` Don Mullis
2006-11-28 21:37 ` Andrew Morton [this message]
2006-11-28 22:50 ` [PATCH 1/2 -mm] fault-injection: safer defaults, trivial optimization, cleanup Don Mullis
2006-11-29 0:05 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061128133754.bad99ddb.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=dwm@meer.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mita@miraclelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox