From: Andi Kleen <ak@suse.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] x86_64: fix earlyprintk=...,keep regression
Date: Tue, 28 Nov 2006 19:57:07 +0100 [thread overview]
Message-ID: <200611281957.07362.ak@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0611281048170.4244@woody.osdl.org>
>
> Or is there some reason you really _want_ "keep" to be different? If so,
> it should probably be commented on.
It's just that keep is the only option that can only be at the end, all
others can be followed by more, so it
made minor sense to use strcmp() to match the \0 too. But using strncmp
everywhere is fine too since the syntax checking on these things is always
quite weak and it probably doesn't make much difference either way.
I would have gone with Ingo's fix, but if you prefer strncmp..?
-Andi
next prev parent reply other threads:[~2006-11-28 18:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-28 8:14 [patch] x86_64: fix earlyprintk=...,keep regression Ingo Molnar
2006-11-28 18:52 ` Linus Torvalds
2006-11-28 18:56 ` Linus Torvalds
2006-11-28 18:57 ` Andi Kleen [this message]
2006-11-28 19:56 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611281957.07362.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox