RE: [PATCH 2.6.19-rc6] i2c-i801: SMBus patch for Intel ICH9

RE: [PATCH 2.6.19-rc6] i2c-i801: SMBus patch for Intel ICH9

[Gaston, Jason D]

Jean,

I send the patches you requested.  Please let me know if you see anything that needs to change.

Thanks,

Jason



>-----Original Message-----
>From: Jean Delvare [mailto:khali@linux-fr.org]
>Sent: Thursday, November 23, 2006 4:10 AM
>To: Gaston, Jason D
>Cc: linux-kernel@vger.kernel.org; gregkh@suse.de; i2c@lm-sensors.org
>Subject: Re: [PATCH 2.6.19-rc6] i2c-i801: SMBus patch for Intel ICH9
>
>Hi Jason,
>
>On Wed, 22 Nov 2006 15:19:12 -0800, Jason Gaston wrote:
>> This updated patch adds the Intel ICH9 LPC and SMBus Controller DID's.
>> This patch relies on the irq ICH9 patch to pci_ids.h.
>
>Looks good. Care to also update Documentation/i2c/busses/i2c-i801? I
>see it misses at least the ICH8 and ESB2 as well.
>
>I would also appreciate an update to lm_sensors' sensors-detect script,
>if you could send a patch to the sensors list.
>
>> Signed-off-by:  Jason Gaston <jason.d.gaston@intel.com>
>>
>> --- linux-2.6.19-rc6/drivers/i2c/busses/i2c-i801.c.orig	2006-11-22
>06:17:20.000000000 -0800
>> +++ linux-2.6.19-rc6/drivers/i2c/busses/i2c-i801.c	2006-11-22
>06:27:12.000000000 -0800
>> @@ -33,6 +33,7 @@
>>      ICH7		27DA
>>      ESB2		269B
>>      ICH8		283E
>> +    ICH9		2930
>>      This driver supports several versions of Intel's I/O Controller Hubs
>(ICH).
>>      For SMBus support, they are similar to the PIIX4 and are part
>>      of Intel's '810' and other chipsets.
>> @@ -457,6 +458,7 @@
>>  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_17) },
>>  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB2_17) },
>>  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH8_5) },
>> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH9_6) },
>>  	{ 0, }
>>  };
>>
>> --- linux-2.6.19-rc6/drivers/i2c/busses/Kconfig.orig	2006-11-22
>07:05:25.000000000 -0800
>> +++ linux-2.6.19-rc6/drivers/i2c/busses/Kconfig	2006-11-22
>07:05:36.000000000 -0800
>> @@ -125,6 +125,7 @@
>>  	    ICH7
>>  	    ESB2
>>  	    ICH8
>> +	    ICH9
>>
>>  	  This driver can also be built as a module.  If so, the module
>>  	  will be called i2c-i801.
>
>Thanks,
>--
>Jean Delvare

Re: [PATCH 2.6.19-rc6] i2c-i801: SMBus patch for Intel ICH9

[Jean Delvare]

On Mon, 27 Nov 2006 11:20:39 -0800, Gaston, Jason D wrote:
> Jean,
> 
> I send the patches you requested.  Please let me know if you
> see anything that needs to change.

Looks all OK, thanks!

-- 
Jean Delvare

[PATCH 2.6.19-rc6] i2c-i801: SMBus patch for Intel ICH9

[Jason Gaston]

This updated patch adds the Intel ICH9 LPC and SMBus Controller DID's.  This patch relies on the irq ICH9 patch to pci_ids.h.

Signed-off-by:  Jason Gaston <jason.d.gaston@intel.com>

--- linux-2.6.19-rc6/drivers/i2c/busses/i2c-i801.c.orig	2006-11-22 06:17:20.000000000 -0800
+++ linux-2.6.19-rc6/drivers/i2c/busses/i2c-i801.c	2006-11-22 06:27:12.000000000 -0800
@@ -33,6 +33,7 @@
     ICH7		27DA
     ESB2		269B
     ICH8		283E
+    ICH9		2930
     This driver supports several versions of Intel's I/O Controller Hubs (ICH).
     For SMBus support, they are similar to the PIIX4 and are part
     of Intel's '810' and other chipsets.
@@ -457,6 +458,7 @@
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_17) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB2_17) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH8_5) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH9_6) },
 	{ 0, }
 };
 
--- linux-2.6.19-rc6/drivers/i2c/busses/Kconfig.orig	2006-11-22 07:05:25.000000000 -0800
+++ linux-2.6.19-rc6/drivers/i2c/busses/Kconfig	2006-11-22 07:05:36.000000000 -0800
@@ -125,6 +125,7 @@
 	    ICH7
 	    ESB2
 	    ICH8
+	    ICH9
 
 	  This driver can also be built as a module.  If so, the module
 	  will be called i2c-i801.

Re: [PATCH 2.6.19-rc6] i2c-i801: SMBus patch for Intel ICH9

[Jean Delvare]

Hi Jason,

On Wed, 22 Nov 2006 15:19:12 -0800, Jason Gaston wrote:
> This updated patch adds the Intel ICH9 LPC and SMBus Controller DID's.
> This patch relies on the irq ICH9 patch to pci_ids.h.

Looks good. Care to also update Documentation/i2c/busses/i2c-i801? I
see it misses at least the ICH8 and ESB2 as well.

I would also appreciate an update to lm_sensors' sensors-detect script,
if you could send a patch to the sensors list.

> Signed-off-by:  Jason Gaston <jason.d.gaston@intel.com>
> 
> --- linux-2.6.19-rc6/drivers/i2c/busses/i2c-i801.c.orig	2006-11-22 06:17:20.000000000 -0800
> +++ linux-2.6.19-rc6/drivers/i2c/busses/i2c-i801.c	2006-11-22 06:27:12.000000000 -0800
> @@ -33,6 +33,7 @@
>      ICH7		27DA
>      ESB2		269B
>      ICH8		283E
> +    ICH9		2930
>      This driver supports several versions of Intel's I/O Controller Hubs (ICH).
>      For SMBus support, they are similar to the PIIX4 and are part
>      of Intel's '810' and other chipsets.
> @@ -457,6 +458,7 @@
>  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_17) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB2_17) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH8_5) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH9_6) },
>  	{ 0, }
>  };
>  
> --- linux-2.6.19-rc6/drivers/i2c/busses/Kconfig.orig	2006-11-22 07:05:25.000000000 -0800
> +++ linux-2.6.19-rc6/drivers/i2c/busses/Kconfig	2006-11-22 07:05:36.000000000 -0800
> @@ -125,6 +125,7 @@
>  	    ICH7
>  	    ESB2
>  	    ICH8
> +	    ICH9
>  
>  	  This driver can also be built as a module.  If so, the module
>  	  will be called i2c-i801.

Thanks,
-- 
Jean Delvare

Re: [PATCH 2.6.19-rc6] i2c-i801: SMBus patch for Intel ICH9

[Arjan van de Ven]

On Thu, 2006-11-23 at 13:09 +0100, Jean Delvare wrote:
> Hi Jason,
> 
> On Wed, 22 Nov 2006 15:19:12 -0800, Jason Gaston wrote:
> > This updated patch adds the Intel ICH9 LPC and SMBus Controller DID's.
> > This patch relies on the irq ICH9 patch to pci_ids.h.
> 
> Looks good. Care to also update Documentation/i2c/busses/i2c-i801? I
> see it misses at least the ICH8 and ESB2 as well.
> 
> I would also appreciate an update to lm_sensors' sensors-detect script,
> if you could send a patch to the sensors list.


hmmm couldn't the sensors-detect script just at runtime look at the pci
tables in the modules? that way no need to duplicate/update all of this
in multiple places...

-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

Re: [PATCH 2.6.19-rc6] i2c-i801: SMBus patch for Intel ICH9

[Jean Delvare]

Hi Arjan,

On Thu, 23 Nov 2006 13:25:57 +0100, Arjan van de Ven wrote:
> On Thu, 2006-11-23 at 13:09 +0100, Jean Delvare wrote:
> > On Wed, 22 Nov 2006 15:19:12 -0800, Jason Gaston wrote:
> > > This updated patch adds the Intel ICH9 LPC and SMBus Controller DID's.
> > > This patch relies on the irq ICH9 patch to pci_ids.h.
> > 
> > Looks good. Care to also update Documentation/i2c/busses/i2c-i801? I
> > see it misses at least the ICH8 and ESB2 as well.
> > 
> > I would also appreciate an update to lm_sensors' sensors-detect script,
> > if you could send a patch to the sensors list.
> 
> 
> hmmm couldn't the sensors-detect script just at runtime look at the pci
> tables in the modules? that way no need to duplicate/update all of this
> in multiple places...

Not really. It is important that sensors-detect knows about chips which
are not supported by the running kernel. That way, we can tell the
users to try the latest version of sensors-detect when they report that
hardware monitoring doesn't work out of the box, and from the output,
we can tell them which kernel they need to upgrade to. If
sensors-detect reads the list of supported devices from the kernel,
instead of having its own, it will no longer work, by definition.

Additionally, sensors-detect is still supposed to support 2.4 kernels,
and I don't think 2.4 drivers advertise the list of devices they
support.

What we could do, on the other hand, is check the detected device ID
against the list the running kernel driver supports, to let the user
know that his/her chip is not supported by his/her kernel. Care to
provide a patch adding this functionality to sensors-detect?

Thanks,
-- 
Jean Delvare