* [2.6 patch] arch/i386/kernel/reboot.c should #include <linux/reboot.h>
@ 2006-11-29 10:04 Adrian Bunk
2006-12-01 5:19 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2006-11-29 10:04 UTC (permalink / raw)
To: linux-kernel
Every file should #include the headers containing the prototypes for
its global functions.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.19-rc6-mm2/arch/i386/kernel/reboot.c.old 2006-11-29 10:06:47.000000000 +0100
+++ linux-2.6.19-rc6-mm2/arch/i386/kernel/reboot.c 2006-11-29 10:06:59.000000000 +0100
@@ -12,6 +12,7 @@
#include <linux/dmi.h>
#include <linux/ctype.h>
#include <linux/pm.h>
+#include <linux/reboot.h>
#include <asm/uaccess.h>
#include <asm/apic.h>
#include <asm/desc.h>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] arch/i386/kernel/reboot.c should #include <linux/reboot.h>
2006-11-29 10:04 [2.6 patch] arch/i386/kernel/reboot.c should #include <linux/reboot.h> Adrian Bunk
@ 2006-12-01 5:19 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2006-12-01 5:19 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
On Wed, 29 Nov 2006 11:04:26 +0100
Adrian Bunk <bunk@stusta.de> wrote:
> Every file should #include the headers containing the prototypes for
> its global functions.
--- a/Makefile~add-gcc-wmissing-prototypes
+++ a/Makefile
@@ -313,7 +313,7 @@ LINUXINCLUDE := -Iinclude \
CPPFLAGS := -D__KERNEL__ $(LINUXINCLUDE)
CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
- -fno-strict-aliasing -fno-common
+ -fno-strict-aliasing -fno-common -Wmissing-prototypes
AFLAGS := -D__ASSEMBLY__
# Read KERNELRELEASE from include/config/kernel.release (if it exists)
_
Have fun...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-12-01 5:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-29 10:04 [2.6 patch] arch/i386/kernel/reboot.c should #include <linux/reboot.h> Adrian Bunk
2006-12-01 5:19 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox