From: Christoph Hellwig <hch@infradead.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: hch@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fs/sysv/: proper prototypes for 2 functions
Date: Wed, 29 Nov 2006 10:06:00 +0000 [thread overview]
Message-ID: <20061129100600.GA28151@infradead.org> (raw)
In-Reply-To: <20061129100405.GI11084@stusta.de>
On Wed, Nov 29, 2006 at 11:04:05AM +0100, Adrian Bunk wrote:
> This patch adds proper prototypes for sysv_{init,destroy}_icache()
> in sysv.h
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> fs/sysv/super.c | 3 ---
> fs/sysv/sysv.h | 3 +++
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> --- linux-2.6.19-rc6-mm2/fs/sysv/sysv.h.old 2006-11-29 09:21:02.000000000 +0100
> +++ linux-2.6.19-rc6-mm2/fs/sysv/sysv.h 2006-11-29 09:21:52.000000000 +0100
> @@ -143,6 +143,9 @@
> extern int sysv_sync_file(struct file *, struct dentry *, int);
> extern void sysv_set_inode(struct inode *, dev_t);
> extern int sysv_getattr(struct vfsmount *, struct dentry *, struct kstat *);
> +int sysv_init_icache(void);
> +void sysv_destroy_icache(void);
Please follow the style used in the rest of the file and add the
extern keyword.
> +
And don't add a superflous blank line.
Except for that the patch is fine.
next prev parent reply other threads:[~2006-11-29 10:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-29 10:04 [2.6 patch] fs/sysv/: proper prototypes for 2 functions Adrian Bunk
2006-11-29 10:06 ` Christoph Hellwig [this message]
2006-11-29 10:57 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2006-12-11 20:42 Adrian Bunk
2006-12-12 10:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061129100600.GA28151@infradead.org \
--to=hch@infradead.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox