* [2.6 patch] fs/sysv/: proper prototypes for 2 functions
@ 2006-11-29 10:04 Adrian Bunk
2006-11-29 10:06 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2006-11-29 10:04 UTC (permalink / raw)
To: hch; +Cc: linux-kernel
This patch adds proper prototypes for sysv_{init,destroy}_icache()
in sysv.h
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/sysv/super.c | 3 ---
fs/sysv/sysv.h | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.19-rc6-mm2/fs/sysv/sysv.h.old 2006-11-29 09:21:02.000000000 +0100
+++ linux-2.6.19-rc6-mm2/fs/sysv/sysv.h 2006-11-29 09:21:52.000000000 +0100
@@ -143,6 +143,9 @@
extern int sysv_sync_file(struct file *, struct dentry *, int);
extern void sysv_set_inode(struct inode *, dev_t);
extern int sysv_getattr(struct vfsmount *, struct dentry *, struct kstat *);
+int sysv_init_icache(void);
+void sysv_destroy_icache(void);
+
/* dir.c */
extern struct sysv_dir_entry *sysv_find_entry(struct dentry *, struct page **);
--- linux-2.6.19-rc6-mm2/fs/sysv/super.c.old 2006-11-29 09:21:55.000000000 +0100
+++ linux-2.6.19-rc6-mm2/fs/sysv/super.c 2006-11-29 09:22:04.000000000 +0100
@@ -528,9 +528,6 @@
.fs_flags = FS_REQUIRES_DEV,
};
-extern int sysv_init_icache(void) __init;
-extern void sysv_destroy_icache(void);
-
static int __init init_sysv_fs(void)
{
int error;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.6 patch] fs/sysv/: proper prototypes for 2 functions
2006-11-29 10:04 [2.6 patch] fs/sysv/: proper prototypes for 2 functions Adrian Bunk
@ 2006-11-29 10:06 ` Christoph Hellwig
2006-11-29 10:57 ` Adrian Bunk
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2006-11-29 10:06 UTC (permalink / raw)
To: Adrian Bunk; +Cc: hch, linux-kernel
On Wed, Nov 29, 2006 at 11:04:05AM +0100, Adrian Bunk wrote:
> This patch adds proper prototypes for sysv_{init,destroy}_icache()
> in sysv.h
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> fs/sysv/super.c | 3 ---
> fs/sysv/sysv.h | 3 +++
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> --- linux-2.6.19-rc6-mm2/fs/sysv/sysv.h.old 2006-11-29 09:21:02.000000000 +0100
> +++ linux-2.6.19-rc6-mm2/fs/sysv/sysv.h 2006-11-29 09:21:52.000000000 +0100
> @@ -143,6 +143,9 @@
> extern int sysv_sync_file(struct file *, struct dentry *, int);
> extern void sysv_set_inode(struct inode *, dev_t);
> extern int sysv_getattr(struct vfsmount *, struct dentry *, struct kstat *);
> +int sysv_init_icache(void);
> +void sysv_destroy_icache(void);
Please follow the style used in the rest of the file and add the
extern keyword.
> +
And don't add a superflous blank line.
Except for that the patch is fine.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.6 patch] fs/sysv/: proper prototypes for 2 functions
2006-11-29 10:06 ` Christoph Hellwig
@ 2006-11-29 10:57 ` Adrian Bunk
0 siblings, 0 replies; 5+ messages in thread
From: Adrian Bunk @ 2006-11-29 10:57 UTC (permalink / raw)
To: Christoph Hellwig, linux-kernel
On Wed, Nov 29, 2006 at 10:06:00AM +0000, Christoph Hellwig wrote:
> On Wed, Nov 29, 2006 at 11:04:05AM +0100, Adrian Bunk wrote:
> > This patch adds proper prototypes for sysv_{init,destroy}_icache()
> > in sysv.h
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> > ---
> >
> > fs/sysv/super.c | 3 ---
> > fs/sysv/sysv.h | 3 +++
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > --- linux-2.6.19-rc6-mm2/fs/sysv/sysv.h.old 2006-11-29 09:21:02.000000000 +0100
> > +++ linux-2.6.19-rc6-mm2/fs/sysv/sysv.h 2006-11-29 09:21:52.000000000 +0100
> > @@ -143,6 +143,9 @@
> > extern int sysv_sync_file(struct file *, struct dentry *, int);
> > extern void sysv_set_inode(struct inode *, dev_t);
> > extern int sysv_getattr(struct vfsmount *, struct dentry *, struct kstat *);
> > +int sysv_init_icache(void);
> > +void sysv_destroy_icache(void);
>
> Please follow the style used in the rest of the file and add the
> extern keyword.
Is it acceptable to remove all the extern's instead?
> > +
>
> And don't add a superflous blank line.
>
> Except for that the patch is fine.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 5+ messages in thread
* [2.6 patch] fs/sysv/: proper prototypes for 2 functions
@ 2006-12-11 20:42 Adrian Bunk
2006-12-12 10:33 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2006-12-11 20:42 UTC (permalink / raw)
To: hch; +Cc: linux-kernel
This patch adds proper prototypes for sysv_{init,destroy}_icache()
in sysv.h
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/sysv/super.c | 3 ---
fs/sysv/sysv.h | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.19-rc6-mm2/fs/sysv/sysv.h.old 2006-11-29 09:21:02.000000000 +0100
+++ linux-2.6.19-rc6-mm2/fs/sysv/sysv.h 2006-11-29 09:21:52.000000000 +0100
@@ -143,6 +143,9 @@
extern int sysv_sync_file(struct file *, struct dentry *, int);
extern void sysv_set_inode(struct inode *, dev_t);
extern int sysv_getattr(struct vfsmount *, struct dentry *, struct kstat *);
+extern int sysv_init_icache(void);
+extern void sysv_destroy_icache(void);
+
/* dir.c */
extern struct sysv_dir_entry *sysv_find_entry(struct dentry *, struct page **);
--- linux-2.6.19-rc6-mm2/fs/sysv/super.c.old 2006-11-29 09:21:55.000000000 +0100
+++ linux-2.6.19-rc6-mm2/fs/sysv/super.c 2006-11-29 09:22:04.000000000 +0100
@@ -528,9 +528,6 @@
.fs_flags = FS_REQUIRES_DEV,
};
-extern int sysv_init_icache(void) __init;
-extern void sysv_destroy_icache(void);
-
static int __init init_sysv_fs(void)
{
int error;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.6 patch] fs/sysv/: proper prototypes for 2 functions
2006-12-11 20:42 Adrian Bunk
@ 2006-12-12 10:33 ` Christoph Hellwig
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2006-12-12 10:33 UTC (permalink / raw)
To: Adrian Bunk; +Cc: hch, linux-kernel
On Mon, Dec 11, 2006 at 09:42:25PM +0100, Adrian Bunk wrote:
> This patch adds proper prototypes for sysv_{init,destroy}_icache()
> in sysv.h
OK.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-12-12 10:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-29 10:04 [2.6 patch] fs/sysv/: proper prototypes for 2 functions Adrian Bunk
2006-11-29 10:06 ` Christoph Hellwig
2006-11-29 10:57 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2006-12-11 20:42 Adrian Bunk
2006-12-12 10:33 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox