From: Stephen Hemminger <shemminger@osdl.org>
To: linux-kernel@vger.kernel.org
Subject: Re: net: sk98lin bracket question
Date: Wed, 29 Nov 2006 14:52:16 -0800 [thread overview]
Message-ID: <20061129145216.0722651b@freekitty> (raw)
In-Reply-To: 200611292335.08563.m.kozlowski@tuxland.pl
On Wed, 29 Nov 2006 23:35:07 +0100
Mariusz Kozlowski <m.kozlowski@tuxland.pl> wrote:
> Hello,
>
> Somewhere below is either one extra or one missing bracket. Any idea how to fix that?
>
> Is the patch below correct?
>
> --- linux-2.6.19-rc6-mm2-a/drivers/net/sk98lin/skgesirq.c 2006-11-16 05:03:40.000000000 +0100
> +++ linux-2.6.19-rc6-mm2-b/drivers/net/sk98lin/skgesirq.c 2006-11-29 23:32:02.000000000 +0100
> @@ -1319,7 +1319,7 @@ SK_BOOL AutoNeg) /* Is Auto-negotiation
> SkXmPhyRead(pAC, IoC, Port, PHY_BCOM_INT_STAT, &Isrc);
>
> #ifdef xDEBUG
> - if ((Isrc & ~(PHY_B_IS_HCT | PHY_B_IS_LCT) ==
> + if ((Isrc & ~(PHY_B_IS_HCT | PHY_B_IS_LCT)) ==
> (PHY_B_IS_SCR_S_ER | PHY_B_IS_RRS_CHANGE | PHY_B_IS_LRS_CHANGE)) {
>
> SK_U32 Stat1, Stat2, Stat3;
>
>
> PS. Who is the maintainer of this driver?
>
Nobody is maintaining this driver, it is being obsoleted and replaced by skge.
--
Stephen Hemminger <shemminger@osdl.org>
prev parent reply other threads:[~2006-11-29 22:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-29 22:35 net: sk98lin bracket question Mariusz Kozlowski
2006-11-29 22:52 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061129145216.0722651b@freekitty \
--to=shemminger@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox