* net: sk98lin bracket question
@ 2006-11-29 22:35 Mariusz Kozlowski
2006-11-29 22:52 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Mariusz Kozlowski @ 2006-11-29 22:35 UTC (permalink / raw)
To: linux-kernel
Hello,
Somewhere below is either one extra or one missing bracket. Any idea how to fix that?
Is the patch below correct?
--- linux-2.6.19-rc6-mm2-a/drivers/net/sk98lin/skgesirq.c 2006-11-16 05:03:40.000000000 +0100
+++ linux-2.6.19-rc6-mm2-b/drivers/net/sk98lin/skgesirq.c 2006-11-29 23:32:02.000000000 +0100
@@ -1319,7 +1319,7 @@ SK_BOOL AutoNeg) /* Is Auto-negotiation
SkXmPhyRead(pAC, IoC, Port, PHY_BCOM_INT_STAT, &Isrc);
#ifdef xDEBUG
- if ((Isrc & ~(PHY_B_IS_HCT | PHY_B_IS_LCT) ==
+ if ((Isrc & ~(PHY_B_IS_HCT | PHY_B_IS_LCT)) ==
(PHY_B_IS_SCR_S_ER | PHY_B_IS_RRS_CHANGE | PHY_B_IS_LRS_CHANGE)) {
SK_U32 Stat1, Stat2, Stat3;
PS. Who is the maintainer of this driver?
--
Regards,
Mariusz Kozlowski
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: net: sk98lin bracket question
2006-11-29 22:35 net: sk98lin bracket question Mariusz Kozlowski
@ 2006-11-29 22:52 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2006-11-29 22:52 UTC (permalink / raw)
To: linux-kernel
On Wed, 29 Nov 2006 23:35:07 +0100
Mariusz Kozlowski <m.kozlowski@tuxland.pl> wrote:
> Hello,
>
> Somewhere below is either one extra or one missing bracket. Any idea how to fix that?
>
> Is the patch below correct?
>
> --- linux-2.6.19-rc6-mm2-a/drivers/net/sk98lin/skgesirq.c 2006-11-16 05:03:40.000000000 +0100
> +++ linux-2.6.19-rc6-mm2-b/drivers/net/sk98lin/skgesirq.c 2006-11-29 23:32:02.000000000 +0100
> @@ -1319,7 +1319,7 @@ SK_BOOL AutoNeg) /* Is Auto-negotiation
> SkXmPhyRead(pAC, IoC, Port, PHY_BCOM_INT_STAT, &Isrc);
>
> #ifdef xDEBUG
> - if ((Isrc & ~(PHY_B_IS_HCT | PHY_B_IS_LCT) ==
> + if ((Isrc & ~(PHY_B_IS_HCT | PHY_B_IS_LCT)) ==
> (PHY_B_IS_SCR_S_ER | PHY_B_IS_RRS_CHANGE | PHY_B_IS_LRS_CHANGE)) {
>
> SK_U32 Stat1, Stat2, Stat3;
>
>
> PS. Who is the maintainer of this driver?
>
Nobody is maintaining this driver, it is being obsoleted and replaced by skge.
--
Stephen Hemminger <shemminger@osdl.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-29 22:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-29 22:35 net: sk98lin bracket question Mariusz Kozlowski
2006-11-29 22:52 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox