From: Torsten Ertbjerg Rasmussen <tr@newtec.dk>
To: Alessandro Zummo <alessandro.zummo@towertech.it>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: ds1743 support
Date: Thu, 30 Nov 2006 10:23:55 +0100 [thread overview]
Message-ID: <200611301023.55196.tr@newtec.dk> (raw)
In-Reply-To: <20061130094723.6ab9e1d3@inspiron>
On Thursday 30 November 2006 09:47, you wrote:
> On Thu, 30 Nov 2006 08:12:02 +0100
>
> Torsten Ertbjerg Rasmussen <tr@newtec.dk> wrote:
> > The real time clocks ds1742 and ds1743 differs only in the size of the
> > nvram. This patch changes the existing ds1742 driver to support also
> > ds1743. The main change is that the nvram size is determined from the
> > resource attached to the device.
> >
> >
> > + pdata->ioaddr_rtc = ioaddr + pdata->size_nvram;
> >
> > /* turn RTC on if it was not on */
> > + ioaddr = pdata->ioaddr_rtc;
> > sec = readb(ioaddr + RTC_SECONDS);
>
> why not
> sec = readb(pdata->ioaddr_rtc + RTC_SECONDS);
> ?
ioaddr is used several times below this point, so diff would be larger.
In the original code, ioaddr points to beginning of nvram and RTC_SECONDS
implicitly adds the nvram size. Now the nvram size is removed from
RTC_SECONDS (and other RTC_*) so ioaddr must point to start of rtc-data.
Regards,
Torsten Rasmussen
>
>
> Acked-by: Alessandro Zummo <a.zummo@towertech.it>
next prev parent reply other threads:[~2006-11-30 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 7:12 [PATCH] rtc: ds1743 support Torsten Ertbjerg Rasmussen
2006-11-30 8:47 ` Alessandro Zummo
2006-11-30 9:23 ` Torsten Ertbjerg Rasmussen [this message]
2006-11-30 13:23 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611301023.55196.tr@newtec.dk \
--to=tr@newtec.dk \
--cc=akpm@osdl.org \
--cc=alessandro.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox