public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Ingo Molnar <mingo@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>,
	lkml <linux-kernel@vger.kernel.org>,
	ak@suse.de
Subject: Re: [PATCH -mm] x86_64 UP needs smp_call_function_single
Date: Thu, 30 Nov 2006 14:11:40 -0800	[thread overview]
Message-ID: <20061130141140.a1b7d7cc.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1164870000.11036.23.camel@earth>

On Thu, 30 Nov 2006 08:00:00 +0100 Ingo Molnar wrote:

> On Wed, 2006-11-29 at 17:45 -0800, Andrew Morton wrote:
> > No, I think this patch is right - the declaration of the CONFIG_SMP
> > smp_call_function_single() is in linux/smp.h so the !CONFIG_SMP
> > declaration
> > or definition should be there too.
> > 
> > It's still buggy though.  It should disable local interrupts around
> > the
> > call to match the SMP version.  I'll fix that separately. 
> 
> hm, didnt i send an updated patch for that already? See the patch below,
> from many days ago. I sent it after the tsc-sync-rewrite patch.

Hi Ingo,

Has there been a patch for this one?  (UP again, not SMP)

drivers/input/ff-memless.c:384: warning: implicit declaration of function 'local_bh_disable'
drivers/input/ff-memless.c:393: warning: implicit declaration of function 'local_bh_enable'

Thanks,
---
~Randy
config:  http://oss.oracle.com/~rdunlap/configs/config-input-up-header

  parent reply	other threads:[~2006-11-30 22:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-30  1:01 [PATCH -mm] x86_64 UP needs smp_call_function_single Randy Dunlap
2006-11-30  1:45 ` Andrew Morton
2006-11-30  7:00   ` Ingo Molnar
2006-11-30  7:54     ` Andrew Morton
2006-11-30  9:22       ` Ingo Molnar
2006-11-30  9:35         ` Andrew Morton
2006-11-30 22:11     ` Randy Dunlap [this message]
2006-11-30 22:27       ` Andrew Morton
2006-11-30 22:31         ` Randy Dunlap
2006-11-30 23:14         ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061130141140.a1b7d7cc.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox