From: Andy Isaacson <adi@hexapodia.org>
To: Adrian Bunk <bunk@stusta.de>, David Woodhouse <dwmw2@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Jarkko Lavinen <jarkko.lavinen@nokia.com>
Subject: Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static
Date: Thu, 30 Nov 2006 10:45:56 -0800 [thread overview]
Message-ID: <20061130184556.GA23293@hexapodia.org> (raw)
In-Reply-To: <1164752386.14595.24.camel@pmac.infradead.org> <20061125191541.GH3702@stusta.de>
On Sat, Nov 25, 2006 at 08:15:41PM +0100, Adrian Bunk wrote:
> This patch makes the needlessly global mtdpart_setup() static.
>
> @@ -346,7 +346,7 @@
> *
> * This function needs to be visible for bootloaders.
> */
> -int mtdpart_setup(char *s)
> +static int mtdpart_setup(char *s)
> {
> cmdline = s;
> return 1;
Jarkko,
You're recorded as submitting the original patch to make this
non-static:
http://linux.bkbits.net:8080/linux-2.6/diffs/drivers/mtd/cmdlinepart.c@1.11?nav=index.html|src/|src/drivers|src/drivers/mtd|hist/drivers/mtd/cmdlinepart.c
Is this change correct?
If so, it should also delete the "needs to be visible" comment.
-andy
next prev parent reply other threads:[~2006-11-30 18:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-25 19:15 [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static Adrian Bunk
2006-11-28 22:19 ` David Woodhouse
2006-11-30 18:45 ` Andy Isaacson [this message]
2006-12-01 13:41 ` Jarkko Lavinen
-- strict thread matches above, loose matches on Subject: below --
2006-06-26 22:02 Adrian Bunk
2006-06-27 13:49 ` David Woodhouse
2006-06-29 17:32 ` Adrian Bunk
2006-07-09 9:12 ` David Woodhouse
2006-07-09 16:12 ` Juha Yrjölä
2006-07-10 10:56 ` Sergei Shtylyov
2006-07-10 11:37 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061130184556.GA23293@hexapodia.org \
--to=adi@hexapodia.org \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=dwmw2@infradead.org \
--cc=jarkko.lavinen@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox