From: Paul Mundt <lethal@linux-sh.org>
To: Paul Jackson <pj@sgi.com>
Cc: Komal Shah <komal.shah802003@gmail.com>,
"M. R. Brown" <mrbrown@0xd6.org>,
linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: bitmap?_find_free_region and bitmap_full arg doubts
Date: Fri, 1 Dec 2006 09:42:29 +0900 [thread overview]
Message-ID: <20061201004229.GA25702@linux-sh.org> (raw)
In-Reply-To: <20061130161008.5417c8b4.pj@sgi.com>
On Thu, Nov 30, 2006 at 04:10:08PM -0800, Paul Jackson wrote:
> The call to bitmap_find_free_region(), in arch/sh/kernel/cpu/sh4/sq.c
> looks bogus:
>
> page = bitmap_find_free_region(sq_bitmap, 0x04000000,
> get_order(map->size));
>
> It says the bitmap has 0x04000000 bits. This would take 0x04000000 / 8
> which is 8388608 (decimal) bytes to hold. That's an insanely
> huge bitmap - 8 million bytes worth of bits.
>
Ouch, you're right, for some reason we missed the >> PAGE_SHIFT here,
even though it was handled properly in sq_api_init(). I suppose we
haven't hit this in practice as most of the users end up being quite
small. I'll fix it up. Good catch, thanks!
next prev parent reply other threads:[~2006-12-01 0:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 15:33 bitmap_find_free_region and bitmap_full arg doubts Komal Shah
2006-12-01 0:10 ` Paul Jackson
2006-12-01 0:42 ` Paul Mundt [this message]
2006-12-01 1:01 ` bitmap?_find_free_region " Paul Jackson
2006-12-01 8:40 ` bitmap_find_free_region " Komal Shah
2006-12-01 9:54 ` Komal Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061201004229.GA25702@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@osdl.org \
--cc=komal.shah802003@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mrbrown@0xd6.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox