public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [patch]VMSPLIT_2G conflicts with PAE
Date: Fri, 1 Dec 2006 08:55:20 +0100	[thread overview]
Message-ID: <20061201075520.GD5400@kernel.dk> (raw)
In-Reply-To: <1164944925.1918.5.camel@sli10-conroe.sh.intel.com>

On Fri, Dec 01 2006, Shaohua Li wrote:
> PAGE_OFFSET is 0x78000000 with VMSPLIT_2G, this address is in the middle
> of the second pgd entry with pae enabled. This breaks assumptions
> (address is aligned to pgd entry's address) in a lot of places like
> pagetable_init. Fixing the assumptions is hard (eg, low mapping). SO I
> just changed the address to 0x80000000.
> 
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
> 
> diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
> index 8ff1c6f..fddfb26 100644
> --- a/arch/i386/Kconfig
> +++ b/arch/i386/Kconfig
> @@ -532,7 +532,7 @@ endchoice
>  config PAGE_OFFSET
>  	hex
>  	default 0xB0000000 if VMSPLIT_3G_OPT
> -	default 0x78000000 if VMSPLIT_2G
> +	default 0x80000000 if VMSPLIT_2G
>  	default 0x40000000 if VMSPLIT_1G
>  	default 0xC0000000

0x78000000 was chosen since it gives you the full 2G as low memory, if
you mave it 0x80000000 then you still have a little highmem and need
that turned on.

-- 
Jens Axboe


  reply	other threads:[~2006-12-01  7:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-01  3:48 [patch]VMSPLIT_2G conflicts with PAE Shaohua Li
2006-12-01  7:55 ` Jens Axboe [this message]
2006-12-01  8:34   ` Shaohua Li
2006-12-02 13:05 ` Pavel Machek
2006-12-02 18:53   ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061201075520.GD5400@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox