public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PM: Fix swsusp debug mode testproc
@ 2006-12-01 10:45 Rafael J. Wysocki
  2006-12-01 10:58 ` Pavel Machek
  0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2006-12-01 10:45 UTC (permalink / raw)
  To: Andrew Morton; +Cc: LKML, Pavel Machek, stable

The 'testproc' swsusp debug mode thaws tasks twice in a row, which is _very_
confusing.  Fix that.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 kernel/power/disk.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.19-rc6-mm2/kernel/power/disk.c
===================================================================
--- linux-2.6.19-rc6-mm2.orig/kernel/power/disk.c	2006-11-28 22:48:35.000000000 +0100
+++ linux-2.6.19-rc6-mm2/kernel/power/disk.c	2006-11-29 23:46:33.000000000 +0100
@@ -153,7 +153,7 @@ int pm_suspend_disk(void)
 		return error;
 
 	if (pm_disk_mode == PM_DISK_TESTPROC)
-		goto Thaw;
+		return 0;
 
 	suspend_console();
 	error = device_suspend(PMSG_FREEZE);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] PM: Fix swsusp debug mode testproc
  2006-12-01 10:45 [PATCH] PM: Fix swsusp debug mode testproc Rafael J. Wysocki
@ 2006-12-01 10:58 ` Pavel Machek
  0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2006-12-01 10:58 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Andrew Morton, LKML, stable

On Fri 2006-12-01 11:45:12, Rafael J. Wysocki wrote:
> The 'testproc' swsusp debug mode thaws tasks twice in a row, which is _very_
> confusing.  Fix that.
> 
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

ACK.

> ---
>  kernel/power/disk.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.19-rc6-mm2/kernel/power/disk.c
> ===================================================================
> --- linux-2.6.19-rc6-mm2.orig/kernel/power/disk.c	2006-11-28 22:48:35.000000000 +0100
> +++ linux-2.6.19-rc6-mm2/kernel/power/disk.c	2006-11-29 23:46:33.000000000 +0100
> @@ -153,7 +153,7 @@ int pm_suspend_disk(void)
>  		return error;
>  
>  	if (pm_disk_mode == PM_DISK_TESTPROC)
> -		goto Thaw;
> +		return 0;
>  
>  	suspend_console();
>  	error = device_suspend(PMSG_FREEZE);

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-12-01 10:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-01 10:45 [PATCH] PM: Fix swsusp debug mode testproc Rafael J. Wysocki
2006-12-01 10:58 ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox