From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Scott Wood <scottwood@freescale.com>
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make platform_device_add_data accept a const pointer.
Date: Fri, 1 Dec 2006 19:34:28 +0000 [thread overview]
Message-ID: <20061201193428.GA4055@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20061201185447.GA19669@ld0162-tx32.am.freescale.net>
On Fri, Dec 01, 2006 at 12:54:47PM -0600, Scott Wood wrote:
> platform_device_add_data() makes a copy of the data that is given to it,
> and thus the parameter can be const. This removes a warning when data
> from get_property() on powerpc is handed to platform_device_add_data(),
> as get_property() returns a const pointer.
Doesn't this cause a compile warning in platform.c, concerning assigning
'data' to struct device's non-const 'platform_data' pointer?
So in essence you're probably just moving the problem rather than really
solving anything.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2006-12-01 19:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 18:54 [PATCH] Make platform_device_add_data accept a const pointer Scott Wood
2006-12-01 19:34 ` Russell King [this message]
2006-12-01 19:37 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061201193428.GA4055@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox